-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AMDGPU] Remove functions with incompatible gws attribute (#78143)
This change is to remove incompatible gws related functions in order to make device-libs work correctly under -O0 for gfx1200+ Co-authored-by: Changpeng Fang <changpeng.fang@amd.com>
- Loading branch information
Showing
2 changed files
with
56 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,54 @@ | ||
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py | ||
; RUN: llc -march=amdgcn -mcpu=gfx1030 -stop-after=amdgpu-remove-incompatible-functions\ | ||
; RUN: -pass-remarks=amdgpu-remove-incompatible-functions %s -o - 2>%t | FileCheck -check-prefixes=COMPATIBLE,IR %s | ||
; RUN: FileCheck -allow-empty --check-prefix=WARN-COMPATIBLE %s < %t | ||
; RUN: llc -march=amdgcn -mcpu=gfx1030 -verify-machineinstrs < %s | ||
|
||
; RUN: llc -march=amdgcn -mcpu=gfx1200 -stop-after=amdgpu-remove-incompatible-functions\ | ||
; RUN: -pass-remarks=amdgpu-remove-incompatible-functions %s -o - 2>%t | FileCheck -check-prefixes=INCOMPATIBLE,IR %s | ||
; RUN: FileCheck --check-prefixes=WARN-INCOMPATIBLE %s < %t | ||
; RUN: llc -march=amdgcn -mcpu=gfx1200 -verify-machineinstrs < %s | ||
|
||
; Note: This test checks the IR, but also has a run line to codegen the file just to check we | ||
; do not crash when trying to select those functions. | ||
|
||
; WARN-COMPATIBLE-NOT: removing function 'needs_gws': | ||
; WARN-INCOMPATIBLE: removing function 'needs_gws': +gws is not supported on the current target | ||
|
||
|
||
; COMPATIBLE: @GVRefs {{.*}} [ptr @needs_gws] | ||
; INCOMPATIBLE: @GVRefs {{.*}} zeroinitializer | ||
@GVRefs = internal global [1 x ptr] [ | ||
ptr @needs_gws | ||
] | ||
|
||
|
||
; COMPATIBLE: @ConstantExpr = internal global i64 ptrtoint (ptr @needs_gws to i64) | ||
; INCOMPATIBLE: @ConstantExpr = internal global i64 0 | ||
@ConstantExpr = internal global i64 ptrtoint (ptr @needs_gws to i64) | ||
|
||
|
||
; COMPATIBLE: define void @needs_gws | ||
; INCOMPATIBLE-NOT: define void @needs_gws | ||
define void @needs_gws(i32 %val0, i32 %val1) #0 { | ||
call void @llvm.amdgcn.ds.gws.init(i32 %val0, i32 %val1) | ||
call void @llvm.amdgcn.ds.gws.barrier(i32 %val0, i32 %val1) | ||
ret void | ||
} | ||
|
||
; IR: define void @gws_caller( | ||
define void @gws_caller(i32 %val0, i32 %val1) { | ||
; COMPATIBLE: call void @needs_gws( | ||
; INCOMPATIBLE: call void null | ||
call void @needs_gws(i32 %val0, i32 %val1) | ||
; IR: ret void | ||
ret void | ||
} | ||
|
||
declare void @llvm.amdgcn.ds.gws.barrier(i32, i32) #1 | ||
declare void @llvm.amdgcn.ds.gws.init(i32, i32) #2 | ||
|
||
|
||
attributes #0 = { "target-features"="+gws"} | ||
attributes #1 = { convergent inaccessiblememonly nounwind } | ||
attributes #2 = { convergent inaccessiblememonly nounwind writeonly } |