Skip to content

Commit

Permalink
[lldb] Remove basestring references in examples (NFC)
Browse files Browse the repository at this point in the history
`basestring` is Python 2 only.
  • Loading branch information
kastiglione committed Dec 13, 2022
1 parent fa45b2f commit f54497f
Show file tree
Hide file tree
Showing 8 changed files with 11 additions and 51 deletions.
7 changes: 1 addition & 6 deletions lldb/examples/summaries/cocoa/CFArray.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -222,7 +217,7 @@ def CFArray_SummaryProvider(valobj, dict):
logger >> "provider gave me " + str(summary)
if summary is None:
summary = '<variable is not NSArray>'
elif isinstance(summary, basestring):
elif isinstance(summary, str):
pass
else:
# we format it like it were a CFString to make it look the same as
Expand Down
7 changes: 1 addition & 6 deletions lldb/examples/summaries/cocoa/CFBag.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -150,7 +145,7 @@ def CFBag_SummaryProvider(valobj, dict):
# the mask needs to be changed)
if summary is None:
summary = '<variable is not CFBag>'
elif isinstance(summary, basestring):
elif isinstance(summary, str):
pass
else:
if provider.sys_params.is_64_bit:
Expand Down
7 changes: 1 addition & 6 deletions lldb/examples/summaries/cocoa/CFBinaryHeap.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -148,7 +143,7 @@ def CFBinaryHeap_SummaryProvider(valobj, dict):
# the mask needs to be changed)
if summary is None:
summary = '<variable is not CFBinaryHeap>'
elif isinstance(summary, basestring):
elif isinstance(summary, str):
pass
else:
if provider.sys_params.is_64_bit:
Expand Down
9 changes: 2 additions & 7 deletions lldb/examples/summaries/cocoa/CFDictionary.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -227,7 +222,7 @@ def CFDictionary_SummaryProvider(valobj, dict):
logger >> "got summary " + str(summary)
if summary is None:
return '<variable is not NSDictionary>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summary
return str(summary) + (" key/value pairs" if summary !=
1 else " key/value pair")
Expand All @@ -249,7 +244,7 @@ def CFDictionary_SummaryProvider2(valobj, dict):
logger >> "got summary " + str(summary)
if summary is None:
summary = '<variable is not CFDictionary>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summary
else:
# needed on OSX Mountain Lion
Expand Down
9 changes: 2 additions & 7 deletions lldb/examples/summaries/cocoa/NSData.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -141,7 +136,7 @@ def NSData_SummaryProvider(valobj, dict):
logger >> "got a summary: it is " + str(summary)
if summary is None:
summary = '<variable is not NSData>'
elif isinstance(summary, basestring):
elif isinstance(summary, str):
pass
else:
if summary == 1:
Expand Down Expand Up @@ -169,7 +164,7 @@ def NSData_SummaryProvider2(valobj, dict):
logger >> "got a summary: it is " + str(summary)
if summary is None:
summary = '<variable is not CFData>'
elif isinstance(summary, basestring):
elif isinstance(summary, str):
pass
else:
if summary == 1:
Expand Down
7 changes: 1 addition & 6 deletions lldb/examples/summaries/cocoa/NSIndexSet.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -168,7 +163,7 @@ def NSIndexSet_SummaryProvider(valobj, dict):
logger >> "got summary " + str(summary)
if summary is None:
summary = '<variable is not NSIndexSet>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summary
else:
summary = str(summary) + (' indexes' if summary != 1 else ' index')
Expand Down
7 changes: 1 addition & 6 deletions lldb/examples/summaries/cocoa/NSMachPort.py
Expand Up @@ -13,11 +13,6 @@
import lldb.formatters.metrics
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring =str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -135,7 +130,7 @@ def NSMachPort_SummaryProvider(valobj, dict):
logger >> "got summary " + str(summary)
if summary is None:
summary = '<variable is not NSMachPort>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summay
return 'mach port: ' + str(summary)
return 'Summary Unavailable'
Expand Down
9 changes: 2 additions & 7 deletions lldb/examples/summaries/cocoa/NSSet.py
Expand Up @@ -13,11 +13,6 @@
import CFBag
import lldb.formatters.Logger

try:
basestring
except NameError:
basestring = str

statistics = lldb.formatters.metrics.Metrics()
statistics.add_metric('invalid_isa')
statistics.add_metric('invalid_pointer')
Expand Down Expand Up @@ -247,7 +242,7 @@ def NSSet_SummaryProvider(valobj, dict):
summary = None
if summary is None:
summary = '<variable is not NSSet>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summary
else:
summary = str(summary) + \
Expand Down Expand Up @@ -276,7 +271,7 @@ def NSSet_SummaryProvider2(valobj, dict):
# the mask needs to be changed)
if summary is None:
summary = '<variable is not CFSet>'
if isinstance(summary, basestring):
if isinstance(summary, str):
return summary
else:
if provider.sys_params.is_64_bit:
Expand Down

0 comments on commit f54497f

Please sign in to comment.