Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[AArch64] Move SeparateConstOffsetFromGEPPass before LSR and enable E…
…nableGEPOpt by default. GEP's across basic blocks were not getting splitted due to EnableGEPOpt which was turned off by default. Hence, EarlyCSE missed the opportunity to eliminate common part of GEP's. This can be achieved by simply turning GEP pass on. - This patch moves SeparateConstOffsetFromGEPPass() just before LSR. - It enables EnableGEPOpt by default. Resolves - #50528 Added an unit test. Differential Revision: https://reviews.llvm.org/D128582
- Loading branch information
1 parent
1b7feac
commit f55dbfb
Showing
7 changed files
with
103 additions
and
49 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
llvm/test/Transforms/SeparateConstOffsetFromGEP/AArch64/lit.local.cfg
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,2 @@ | ||
if not 'AArch64' in config.root.targets: | ||
config.unsupported = True |
32 changes: 32 additions & 0 deletions
32
llvm/test/Transforms/SeparateConstOffsetFromGEP/AArch64/split-gep.ll
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,32 @@ | ||
; RUN: llc < %s -O3 -mtriple=aarch64-linux-gnu | FileCheck %s | ||
|
||
%struct = type { i32, i32, i32 } | ||
|
||
define i32 @test1(%struct* %ptr, i64 %idx) { | ||
; CHECK-LABEL: test1: | ||
; CHECK: // %bb.0: | ||
; CHECK-NEXT: mov w8, #12 | ||
; CHECK-NEXT: madd x8, x1, x8, x0 | ||
; CHECK-NEXT: ldr w9, [x8, #4] | ||
; CHECK-NEXT: tbnz w9, #31, .LBB0_2 | ||
; CHECK-NEXT: // %bb.1: | ||
; CHECK-NEXT: mov w0, wzr | ||
; CHECK-NEXT: ret | ||
; CHECK-NEXT: .LBB0_2: // %then | ||
; CHECK-NEXT: ldr w8, [x8, #8] | ||
; CHECK-NEXT: add w0, w9, w8 | ||
; CHECK-NEXT: ret | ||
%gep.1 = getelementptr %struct, %struct* %ptr, i64 %idx, i32 1 | ||
%lv.1 = load i32, i32* %gep.1 | ||
%c = icmp slt i32 %lv.1, 0 | ||
br i1 %c, label %then, label %else | ||
|
||
then: | ||
%gep.2 = getelementptr %struct, %struct* %ptr, i64 %idx, i32 2 | ||
%lv.2 = load i32, i32* %gep.2 | ||
%res = add i32 %lv.1, %lv.2 | ||
ret i32 %res | ||
|
||
else: | ||
ret i32 0 | ||
} |