Skip to content

Commit

Permalink
[NFC] Add an overload for getP1689ModuleDependencyFile without output…
Browse files Browse the repository at this point in the history
… parameters

See the comment of https://reviews.llvm.org/D153114. The current
signature will make the user to misunderstant that it will write files
to the filesystem, while it is not true. This patch adds an overload to
erase the concern. And the overload will be used in the support for
modules in clangd.
  • Loading branch information
ChuanqiXu9 committed Sep 4, 2023
1 parent 1ef1eec commit f585b7d
Showing 1 changed file with 9 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -106,6 +106,15 @@ class DependencyScanningTool {
getP1689ModuleDependencyFile(const clang::tooling::CompileCommand &Command,
StringRef CWD, std::string &MakeformatOutput,
std::string &MakeformatOutputPath);
llvm::Expected<P1689Rule>
getP1689ModuleDependencyFile(const clang::tooling::CompileCommand &Command,
StringRef CWD) {
std::string MakeformatOutput;
std::string MakeformatOutputPath;

return getP1689ModuleDependencyFile(Command, CWD, MakeformatOutput,
MakeformatOutputPath);
}

/// Given a Clang driver command-line for a translation unit, gather the
/// modular dependencies and return the information needed for explicit build.
Expand Down

0 comments on commit f585b7d

Please sign in to comment.