Skip to content

Commit

Permalink
[Release] Don't build during test-release.sh Phase 3 install (#82001)
Browse files Browse the repository at this point in the history
As described in [test-release.sh ninja install does builds in Phase
3](#80999), considerable
parts of Phase 3 of a `test-release.sh` build are run by `ninja
install`, ignoring both `$Verbose` and the parallelism set via `-j NUM`.

This patches fixes this by not specifying any explicit build target for
Phase 3, thus running the full build as usual.

Tested on `sparc64-unknown-linux-gnu`.
  • Loading branch information
rorth committed Feb 20, 2024
1 parent 7661ade commit f6ac598
Showing 1 changed file with 5 additions and 0 deletions.
5 changes: 5 additions & 0 deletions llvm/utils/release/test-release.sh
Original file line number Diff line number Diff line change
Expand Up @@ -537,6 +537,11 @@ function build_llvmCore() {
InstallTarget="$InstallTarget install-builtins"
fi
fi
if [ "$Phase" -eq "3" ]; then
# Build everything at once, with the proper parallelism and verbosity,
# in Phase 3.
BuildTarget=
fi

cd $ObjDir
echo "# Compiling llvm $Release-$RC $Flavor"
Expand Down

0 comments on commit f6ac598

Please sign in to comment.