Skip to content

Commit

Permalink
[X86][FP16] Do not create VBROADCAST_LOAD for f16 without AVX2 (#91125)
Browse files Browse the repository at this point in the history
AVX doesn't provide 16-bit BROADCAST instruction.

Fixes #91005
  • Loading branch information
phoebewang committed May 6, 2024
1 parent 3d6cf53 commit f7bfb07
Show file tree
Hide file tree
Showing 2 changed files with 40 additions and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/lib/Target/X86/X86ISelLowering.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -7414,7 +7414,7 @@ static SDValue lowerBuildVectorAsBroadcast(BuildVectorSDNode *BVOp,
// With pattern matching, the VBROADCAST node may become a VMOVDDUP.
if (ScalarSize == 32 ||
(ScalarSize == 64 && (IsGE256 || Subtarget.hasVLX())) ||
CVT == MVT::f16 ||
(CVT == MVT::f16 && Subtarget.hasAVX2()) ||
(OptForSize && (ScalarSize == 64 || Subtarget.hasAVX2()))) {
const Constant *C = nullptr;
if (ConstantSDNode *CI = dyn_cast<ConstantSDNode>(Ld))
Expand Down
39 changes: 39 additions & 0 deletions llvm/test/CodeGen/X86/pr91005.ll
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py UTC_ARGS: --version 4
; RUN: llc -mtriple=x86_64-unknown-unknown -mattr=+f16c < %s | FileCheck %s

define void @PR91005(ptr %0) minsize {
; CHECK-LABEL: PR91005:
; CHECK: # %bb.0:
; CHECK-NEXT: xorl %eax, %eax
; CHECK-NEXT: testb %al, %al
; CHECK-NEXT: je .LBB0_2
; CHECK-NEXT: # %bb.1:
; CHECK-NEXT: vbroadcastss {{.*#+}} xmm0 = [31744,31744,31744,31744]
; CHECK-NEXT: vpcmpeqw %xmm0, %xmm0, %xmm0
; CHECK-NEXT: vpinsrw $0, {{\.?LCPI[0-9]+_[0-9]+}}(%rip), %xmm0, %xmm1
; CHECK-NEXT: vpand %xmm1, %xmm0, %xmm0
; CHECK-NEXT: vcvtph2ps %xmm0, %xmm0
; CHECK-NEXT: vpxor %xmm1, %xmm1, %xmm1
; CHECK-NEXT: vmulss %xmm1, %xmm0, %xmm0
; CHECK-NEXT: vcvtps2ph $4, %xmm0, %xmm0
; CHECK-NEXT: vmovd %xmm0, %eax
; CHECK-NEXT: movw %ax, (%rdi)
; CHECK-NEXT: .LBB0_2: # %common.ret
; CHECK-NEXT: retq
%2 = bitcast <2 x half> poison to <2 x i16>
%3 = icmp eq <2 x i16> %2, <i16 31744, i16 31744>
br i1 poison, label %4, label %common.ret

common.ret: ; preds = %4, %1
ret void

4: ; preds = %1
%5 = select <2 x i1> %3, <2 x half> <half 0xH3C00, half 0xH3C00>, <2 x half> zeroinitializer
%6 = fmul <2 x half> %5, zeroinitializer
%7 = fsub <2 x half> %6, zeroinitializer
%8 = extractelement <2 x half> %7, i64 0
store half %8, ptr %0, align 2
br label %common.ret
}

declare <2 x half> @llvm.fabs.v2f16(<2 x half>)

0 comments on commit f7bfb07

Please sign in to comment.