Skip to content

Commit

Permalink
[TwoAddressInstruction] Remove ad hoc machine verification
Browse files Browse the repository at this point in the history
With the -early-live-intervals command line flag,
TwoAddressInstructionPass::runOnMachineFunction would call
MachineFunction::verify before returning to check the live intervals.
But there was not much benefit to doing this since -verify-machineinstrs
and LLVM_ENABLE_EXPENSIVE_CHECKS provide a more general way of
scheduling machine verification after every pass.

Also it caused problems on targets like Lanai which are marked as "not
machine verifier clean", since verification would fail for known
target-specific problems which are nothing to do with LiveIntervals.

Differential Revision: https://reviews.llvm.org/D111618
  • Loading branch information
jayfoad committed Oct 12, 2021
1 parent 66e13c7 commit f7ee21a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions llvm/lib/CodeGen/TwoAddressInstructionPass.cpp
Expand Up @@ -1742,9 +1742,6 @@ bool TwoAddressInstructionPass::runOnMachineFunction(MachineFunction &Func) {
}
}

if (LIS)
MF->verify(this, "After two-address instruction pass");

return MadeChange;
}

Expand Down

0 comments on commit f7ee21a

Please sign in to comment.