-
Notifications
You must be signed in to change notification settings - Fork 10.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[CodeGen] Keep track of eagerly emitted globals
An inline virtual function must be emitted, but we need to remember it and emit the same definition again in the future in case later LLVM optimizations stripped it from the Module. The added test case shows the problem; before this patch, it would fail with: Symbols not found: [ _ZN1AD0Ev, _ZN1AD1Ev ] Differential Revision: https://reviews.llvm.org/D156537
- Loading branch information
Showing
2 changed files
with
22 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
// REQUIRES: host-supports-jit | ||
// UNSUPPORTED: system-aix | ||
// RUN: cat %s | clang-repl | FileCheck %s | ||
// RUN: cat %s | clang-repl -Xcc -O2 | FileCheck %s | ||
|
||
extern "C" int printf(const char *, ...); | ||
|
||
struct A { int a; A(int a) : a(a) {} virtual ~A(); }; | ||
|
||
// Then define the virtual destructor as inline out-of-line, in a separate | ||
// PartialTranslationUnit. | ||
inline A::~A() { printf("~A(%d)\n", a); } | ||
|
||
// Create one instance with new and delete it. | ||
A *a1 = new A(1); | ||
delete a1; | ||
// CHECK: ~A(1) | ||
|
||
// Also create one global that will be auto-destructed. | ||
A a2(2); | ||
// CHECK: ~A(2) |