Skip to content

Commit

Permalink
[Transforms][Debugify] Ignore PHI nodes when checking for DebugLocs
Browse files Browse the repository at this point in the history
Fix for: https://bugs.llvm.org/show_bug.cgi?id=37964

Differential Revision: https://reviews.llvm.org/D75242

(cherry picked from commit f64e457)
  • Loading branch information
Pierre-vh authored and vedantk committed Feb 27, 2020
1 parent 94348eb commit f910ad8
Show file tree
Hide file tree
Showing 2 changed files with 36 additions and 1 deletion.
2 changes: 1 addition & 1 deletion llvm/lib/Transforms/Utils/Debugify.cpp
Expand Up @@ -233,7 +233,7 @@ bool checkDebugifyMetadata(Module &M,

// Find missing lines.
for (Instruction &I : instructions(F)) {
if (isa<DbgValueInst>(&I))
if (isa<DbgValueInst>(&I) || isa<PHINode>(&I))
continue;

auto DL = I.getDebugLoc();
Expand Down
35 changes: 35 additions & 0 deletions llvm/test/DebugInfo/pr37964.ll
@@ -0,0 +1,35 @@
; RUN: opt -disable-output -debugify-each -gvn < %s 2>&1 | FileCheck %s

; CHECK-NOT: ERROR: Instruction with empty DebugLoc in function _Z3bazv -- {{%.*}} = phi
; CHECK: CheckFunctionDebugify [Global Value Numbering]: PASS

@foo = dso_local local_unnamed_addr global i32 0, align 4
@x = global i8 17

define dso_local void @_Z3bazv() local_unnamed_addr #0 {
entry:
br label %for.cond

for.cond.loopexit.loopexit: ; preds = %for.inc
br label %for.cond.loopexit

for.cond.loopexit: ; preds = %for.cond.loopexit.loopexit, %for.cond
br label %for.cond

for.cond: ; preds = %for.cond.loopexit, %entry
%.pr = load i32, i32* @foo, align 4
%tobool1 = icmp eq i32 %.pr, 0
br i1 %tobool1, label %for.cond.loopexit, label %for.inc.preheader

for.inc.preheader: ; preds = %for.cond
br label %for.inc

for.inc: ; preds = %for.inc.preheader, %for.inc
%val = load i8, i8* @x
%conv = sext i8 %val to i32
store i32 %conv, i32* @foo, align 4
%tobool = icmp eq i8 %val, 0
br i1 %tobool, label %for.cond.loopexit.loopexit, label %for.inc
}

declare dso_local signext i8 @_Z3barv() local_unnamed_addr #1

0 comments on commit f910ad8

Please sign in to comment.