Revert "[clang][analyzer] Add modeling of 'errno'."

This reverts commit 29b512b. This broke several build bots: https://lab.llvm.org/buildbot/#/builders/86/builds/30183 https://lab.llvm.org/buildbot/#/builders/216/builds/488
llvm · Feb 25, 2022 · f9e8e92 · f9e8e92
1 parent 291450d
commit f9e8e92
Show file tree

Hide file tree

Showing 14 changed files with 9 additions and 512 deletions.
diff --git a/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td b/clang/include/clang/StaticAnalyzer/Checkers/Checkers.td
@@ -348,10 +348,6 @@ def NullableReturnedFromNonnullChecker : Checker<"NullableReturnedFromNonnull">,
 
 let ParentPackage = APIModeling in {
 
-def ErrnoModeling : Checker<"Errno">,
-  HelpText<"Make the special value 'errno' available to other checkers.">,
-  Documentation<NotDocumented>;
-
 def StdCLibraryFunctionsChecker : Checker<"StdCLibraryFunctions">,
   HelpText<"Improve modeling of the C standard library functions">,
   // Uninitialized value check is a mandatory dependency. This Checker asserts
@@ -1560,11 +1556,6 @@ def StreamTesterChecker : Checker<"StreamTester">,
            "purposes.">,
   Documentation<NotDocumented>;
 
-def ErrnoTesterChecker : Checker<"ErrnoTest">,
-  HelpText<"Check modeling aspects of 'errno'.">,
-  Dependencies<[ErrnoModeling]>,
-  Documentation<NotDocumented>;
-
 def ExprInspectionChecker : Checker<"ExprInspection">,
   HelpText<"Check the analyzer's understanding of expressions">,
   Documentation<NotDocumented>;

diff --git a/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h b/clang/include/clang/StaticAnalyzer/Core/PathSensitive/MemRegion.h
@@ -764,8 +764,7 @@ class SymbolicRegion : public SubRegion {
     assert(s->getType()->isAnyPointerType() ||
            s->getType()->isReferenceType() ||
            s->getType()->isBlockPointerType());
-    assert(isa<UnknownSpaceRegion>(sreg) || isa<HeapSpaceRegion>(sreg) ||
-           isa<GlobalSystemSpaceRegion>(sreg));
+    assert(isa<UnknownSpaceRegion>(sreg) || isa<HeapSpaceRegion>(sreg));
   }
 
 public:
@@ -1376,9 +1375,7 @@ class MemRegionManager {
                                         const LocationContext *LC);
 
   /// Retrieve or create a "symbolic" memory region.
-  /// If no memory space is specified, `UnknownSpaceRegion` will be used.
-  const SymbolicRegion *
-  getSymbolicRegion(SymbolRef Sym, const MemSpaceRegion *MemSpace = nullptr);
+  const SymbolicRegion* getSymbolicRegion(SymbolRef Sym);
 
   /// Return a unique symbolic region belonging to heap memory space.
   const SymbolicRegion *getSymbolicHeapRegion(SymbolRef sym);

diff --git a/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt b/clang/lib/StaticAnalyzer/Checkers/CMakeLists.txt
@@ -40,8 +40,6 @@ add_clang_library(clangStaticAnalyzerCheckers
   DynamicTypePropagation.cpp
   DynamicTypeChecker.cpp
   EnumCastOutOfRangeChecker.cpp
-  ErrnoModeling.cpp
-  ErrnoTesterChecker.cpp
   ExprInspectionChecker.cpp
   FixedAddressChecker.cpp
   FuchsiaHandleChecker.cpp

diff --git a/clang/lib/StaticAnalyzer/Checkers/Errno.h b/clang/lib/StaticAnalyzer/Checkers/Errno.h
diff --git a/clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp b/clang/lib/StaticAnalyzer/Checkers/ErrnoModeling.cpp