Skip to content

Commit

Permalink
[RISCV] Test coverage for missing commute of vsadd(u)
Browse files Browse the repository at this point in the history
For some reason, this appears to only happen with fixed length vectors.  Scalable ones commute just fine in all the cases I've seen.
  • Loading branch information
preames committed Jul 7, 2022
1 parent 636bc54 commit fa3783c
Show file tree
Hide file tree
Showing 2 changed files with 26 additions and 0 deletions.
13 changes: 13 additions & 0 deletions llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vsadd.ll
Expand Up @@ -316,6 +316,19 @@ define <2 x i32> @sadd_v2i32_vx(<2 x i32> %va, i32 %b) {
ret <2 x i32> %v
}

define <2 x i32> @sadd_v2i32_vx_commute(<2 x i32> %va, i32 %b) {
; CHECK-LABEL: sadd_v2i32_vx_commute:
; CHECK: # %bb.0:
; CHECK-NEXT: vsetivli zero, 2, e32, mf2, ta, mu
; CHECK-NEXT: vmv.v.x v9, a0
; CHECK-NEXT: vsadd.vv v8, v9, v8
; CHECK-NEXT: ret
%elt.head = insertelement <2 x i32> poison, i32 %b, i32 0
%vb = shufflevector <2 x i32> %elt.head, <2 x i32> poison, <2 x i32> zeroinitializer
%v = call <2 x i32> @llvm.sadd.sat.v2i32(<2 x i32> %vb, <2 x i32> %va)
ret <2 x i32> %v
}

define <2 x i32> @sadd_v2i32_vi(<2 x i32> %va) {
; CHECK-LABEL: sadd_v2i32_vi:
; CHECK: # %bb.0:
Expand Down
13 changes: 13 additions & 0 deletions llvm/test/CodeGen/RISCV/rvv/fixed-vectors-vsaddu.ll
Expand Up @@ -316,6 +316,19 @@ define <2 x i32> @uadd_v2i32_vx(<2 x i32> %va, i32 %b) {
ret <2 x i32> %v
}

define <2 x i32> @uadd_v2i32_vx_commute(<2 x i32> %va, i32 %b) {
; CHECK-LABEL: uadd_v2i32_vx_commute:
; CHECK: # %bb.0:
; CHECK-NEXT: vsetivli zero, 2, e32, mf2, ta, mu
; CHECK-NEXT: vmv.v.x v9, a0
; CHECK-NEXT: vsaddu.vv v8, v9, v8
; CHECK-NEXT: ret
%elt.head = insertelement <2 x i32> poison, i32 %b, i32 0
%vb = shufflevector <2 x i32> %elt.head, <2 x i32> poison, <2 x i32> zeroinitializer
%v = call <2 x i32> @llvm.uadd.sat.v2i32(<2 x i32> %vb, <2 x i32> %va)
ret <2 x i32> %v
}

define <2 x i32> @uadd_v2i32_vi(<2 x i32> %va) {
; CHECK-LABEL: uadd_v2i32_vi:
; CHECK: # %bb.0:
Expand Down

0 comments on commit fa3783c

Please sign in to comment.