Skip to content

Commit

Permalink
[clang][dataflow] Show triangle in <details> element. (#67431)
Browse files Browse the repository at this point in the history
Also, change the mouse cursor into a pointer instead of a text cursor.

This makes it more discoverable that the element can be opened and
closed.
  • Loading branch information
martinboehme committed Sep 28, 2023
1 parent 7ad3825 commit fb933fc
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 3 deletions.
15 changes: 13 additions & 2 deletions clang/lib/Analysis/FlowSensitive/HTMLLogger.css
Original file line number Diff line number Diff line change
Expand Up @@ -123,10 +123,21 @@ code.line:has(.bb-select):before {
font-size: x-small;
flex-grow: 1;
}
.value summary {
.value > summary {
background-color: #ace;
display: flex;
justify-content: space-between;
cursor: pointer;
}
.value > summary::before {
content: '►';
margin-right: 0.5em;
font-size: 0.9em;
}
.value[open] > summary::before {
content: '▼';
}
.value > summary > .location {
margin-left: auto;
}
.value .address {
font-size: xx-small;
Expand Down
2 changes: 1 addition & 1 deletion clang/lib/Analysis/FlowSensitive/HTMLLogger.html
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@
<template data-if="v.value_id"><span class="address">#{{v.value_id}}</span></template>
</span>
<template data-if="v.location">
<span>{{v.type}} <span class="address">@{{v.location}}</span></span>
<span class="location">{{v.type}} <span class="address">@{{v.location}}</span></span>
</template>
</summary>
<template
Expand Down

1 comment on commit fb933fc

@martinboehme
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Breaks buildbots because bundle_resources.py complains about non-ASCII characters. Will revert.

Please sign in to comment.