Skip to content

Commit

Permalink
[clang-repl] Refine fix for linker error: PLT offset too large
Browse files Browse the repository at this point in the history
This is a follow-up improvement after the discussion in #78959
  • Loading branch information
weliveindetail committed Jan 24, 2024
1 parent fe0e632 commit fb9a82b
Showing 1 changed file with 9 additions and 8 deletions.
17 changes: 9 additions & 8 deletions clang/tools/clang-repl/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,13 @@ if(CLANG_PLUGIN_SUPPORT)
export_executable_symbols_for_plugins(clang-repl)
endif()

string(TOUPPER "${CMAKE_SYSTEM_PROCESSOR}" system_processor)
if(system_processor MATCHES "ARM")
set(FLAG_LONG_PLT "-Wl,--long-plt")
llvm_check_linker_flag(CXX ${FLAG_LONG_PLT} LINKER_HAS_FLAG_LONG_PLT)
# Linkers without this flag are assumed to have long PLTs by default
if(LINKER_HAS_FLAG_LONG_PLT)
target_link_options(clang-repl PRIVATE ${FLAG_LONG_PLT})
endif()
# The clang-repl binary can get huge with static linking in debug mode.
# Some 32-bit targets use PLT slots with limited branch range by default and we
# start to exceed this limit, e.g. when linking for arm-linux-gnueabihf with
# gold. This flag tells the linker to build a PLT for the full address range.
# Linkers without this flag are assumed to support proper PLTs by default.
set(flag_long_plt "-Wl,--long-plt")
llvm_check_linker_flag(CXX ${flag_long_plt} HAVE_LINKER_FLAG_LONG_PLT)
if(HAVE_LINKER_FLAG_LONG_PLT)
target_link_options(clang-repl PRIVATE ${flag_long_plt})
endif()

0 comments on commit fb9a82b

Please sign in to comment.