Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[tsan] Fix false positives with GCD dispatch_source_*
We already have interceptors for dispatch_source API (e.g. dispatch_source_set_event_handler), but they currently only handle submission synchronization. We also need to synchronize based on the target queue (serial, concurrent), in other words, we need to use dispatch_callback_wrap. This patch implements that. Differential Revision: http://reviews.llvm.org/D21999 llvm-svn: 274619
- Loading branch information
1 parent
9c6c8e9
commit fd995fe
Showing
2 changed files
with
77 additions
and
24 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,33 @@ | ||
// RUN: %clang_tsan %s -o %t -framework Foundation | ||
// RUN: %env_tsan_opts=ignore_interceptors_accesses=1 %run %t 2>&1 | FileCheck %s | ||
|
||
#import <Foundation/Foundation.h> | ||
|
||
long global; | ||
|
||
int main(int argc, const char *argv[]) { | ||
fprintf(stderr, "Hello world.\n"); | ||
|
||
dispatch_queue_t q = dispatch_queue_create("my.queue", DISPATCH_QUEUE_SERIAL); | ||
dispatch_semaphore_t sem = dispatch_semaphore_create(0); | ||
dispatch_source_t timer = dispatch_source_create(DISPATCH_SOURCE_TYPE_TIMER, 0, 0, q); | ||
long long interval_ms = 10; | ||
dispatch_source_set_timer(timer, dispatch_time(DISPATCH_TIME_NOW, 0), interval_ms * NSEC_PER_MSEC, 0); | ||
dispatch_source_set_event_handler(timer, ^{ | ||
fprintf(stderr, "timer\n"); | ||
global++; | ||
|
||
if (global > 50) { | ||
dispatch_semaphore_signal(sem); | ||
} | ||
}); | ||
dispatch_resume(timer); | ||
|
||
dispatch_semaphore_wait(sem, DISPATCH_TIME_FOREVER); | ||
|
||
fprintf(stderr, "Done.\n"); | ||
} | ||
|
||
// CHECK: Hello world. | ||
// CHECK-NOT: WARNING: ThreadSanitizer | ||
// CHECK: Done. |