Skip to content

Commit

Permalink
[Docs] Mention linking to reviews page when committing
Browse files Browse the repository at this point in the history
Differential Revision: https://reviews.llvm.org/D98695
  • Loading branch information
vaivaswatha committed Mar 16, 2021
1 parent b85d3e2 commit fe990ee
Showing 1 changed file with 3 additions and 0 deletions.
3 changes: 3 additions & 0 deletions llvm/docs/DeveloperPolicy.rst
Original file line number Diff line number Diff line change
Expand Up @@ -291,6 +291,9 @@ Below are some guidelines about the format of the message itself:
related commit. This could be as simple as "Revert commit NNNN because it
caused PR#".

* If the patch has been reviewed, add a link to its review page, as shown
`here <https://www.llvm.org/docs/Phabricator.html#committing-a-change>`_.

For minor violations of these recommendations, the community normally favors
reminding the contributor of this policy over reverting. Minor corrections and
omissions can be handled by sending a reply to the commits mailing list.
Expand Down

0 comments on commit fe990ee

Please sign in to comment.