Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Summary: As discussed on the mailing list [1] we have to make a decision for how to proceed with the modern-type-lookup. This patch removes modern-type-lookup from LLDB. This just removes all the code behind the modern-type-lookup setting but it does *not* remove any code from Clang (i.e., the ExternalASTMerger and the clang-import-test stay around for now). The motivation for this is that I don't think that the current approach of implementing modern-type-lookup will work out. Especially creating a completely new lookup system behind some setting that is never turned on by anyone and then one day make one big switch to the new system seems wrong. It doesn't fit into the way LLVM is developed and has so far made the transition work much more complicated than it has to be. A lot of the benefits that were supposed to come with the modern-type-lookup are related to having a better organization in the way types move across LLDB and having less dependencies on unrelated LLDB code. By just looking at the current code (mostly the ClangASTImporter) I think we can reach the same goals by just incrementally cleaning up, documenting, refactoring and actually testing the existing code we have. [1] http://lists.llvm.org/pipermail/lldb-dev/2019-December/015831.html Reviewers: shafik, martong Subscribers: rnkovacs, christof, arphaman, JDevlieghere, usaxena95, lldb-commits, friss Tags: #lldb Differential Revision: https://reviews.llvm.org/D71562
- Loading branch information
Showing
24 changed files
with
8 additions
and
463 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 changes: 0 additions & 4 deletions
4
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/basic-objc/Makefile
This file was deleted.
Oops, something went wrong.
18 changes: 0 additions & 18 deletions
18
...suite/test/functionalities/modern-type-lookup/basic-objc/TestBasicObjcModernTypeLookup.py
This file was deleted.
Oops, something went wrong.
17 changes: 0 additions & 17 deletions
17
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/basic-objc/main.m
This file was deleted.
Oops, something went wrong.
2 changes: 0 additions & 2 deletions
2
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/basic/Makefile
This file was deleted.
Oops, something went wrong.
21 changes: 0 additions & 21 deletions
21
...thon/lldbsuite/test/functionalities/modern-type-lookup/basic/TestBasicModernTypeLookup.py
This file was deleted.
Oops, something went wrong.
7 changes: 0 additions & 7 deletions
7
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/basic/main.cpp
This file was deleted.
Oops, something went wrong.
3 changes: 0 additions & 3 deletions
3
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/libcxx/Makefile
This file was deleted.
Oops, something went wrong.
23 changes: 0 additions & 23 deletions
23
...on/lldbsuite/test/functionalities/modern-type-lookup/libcxx/TestLibCxxModernTypeLookup.py
This file was deleted.
Oops, something went wrong.
14 changes: 0 additions & 14 deletions
14
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/libcxx/main.cpp
This file was deleted.
Oops, something went wrong.
4 changes: 0 additions & 4 deletions
4
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/objc-modules/Makefile
This file was deleted.
Oops, something went wrong.
26 changes: 0 additions & 26 deletions
26
...te/test/functionalities/modern-type-lookup/objc-modules/TestObjModulesModernTypeLookup.py
This file was deleted.
Oops, something went wrong.
6 changes: 0 additions & 6 deletions
6
lldb/packages/Python/lldbsuite/test/functionalities/modern-type-lookup/objc-modules/main.m
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.