Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[PS4] Support dllimport/export attributes
For PS4 development we support dllimport/export annotations in source code. This patch enables the dllimport/export attributes on PS4 by adding a new function to query the triple for whether dllimport/export are used and using that function to decide whether these attributes are supported. This replaces the current method of checking if the target is Windows. This means we can drop the use of "TargetArch" in the .td file (which is an improvement as dllimport/export support isn't really a function of the architecture). I have included a simple codgen test to show that the attributes are accepted and have an effect on codegen for PS4. I have also enabled the DLLExportStaticLocal and DLLImportStaticLocal attributes, which we support downstream. However, I am unable to write a test for these attributes until other patches for PS4 dllimport/export handling land upstream. Whilst writing this patch I noticed that, as these attributes are internal, they do not need to be target specific (when these attributes are added internally in Clang the target specific checks have already been run); however, I think leaving them target specific is fine because it isn't harmful and they "really are" target specific even if that has no functional impact. Differential Revision: https://reviews.llvm.org/D90442
- Loading branch information
1 parent
a5b899b
commit ff2e24a
Showing
3 changed files
with
43 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
// RUN: %clang_cc1 \ | ||
// RUN: -triple x86_64-scei-ps4 \ | ||
// RUN: -fdeclspec \ | ||
// RUN: -Werror \ | ||
// RUN: -emit-llvm %s -o - | \ | ||
// RUN: FileCheck %s | ||
|
||
__declspec(dllexport) int export_int; | ||
|
||
__declspec(dllimport) int import_int; | ||
|
||
__declspec(dllexport) void export_declared_function(); | ||
|
||
__declspec(dllexport) void export_implemented_function() { | ||
} | ||
|
||
__declspec(dllimport) void import_function(int); | ||
|
||
void call_imported_function() { | ||
export_declared_function(); | ||
return import_function(import_int); | ||
} | ||
|
||
// CHECK-DAG: @import_int = external dllimport | ||
// CHECK-DAG: @export_int = dllexport global i32 0 | ||
// CHECK-DAG: define dllexport void @export_implemented_function() | ||
// CHECK-DAG: declare dllimport void @import_function(i32) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters