Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lld/COFF does not handle /align #42232

Closed
rui314 opened this issue Aug 5, 2019 · 4 comments
Closed

lld/COFF does not handle /align #42232

rui314 opened this issue Aug 5, 2019 · 4 comments
Labels
bugzilla Issues migrated from bugzilla lld:COFF

Comments

@rui314
Copy link
Member

rui314 commented Aug 5, 2019

Bugzilla Link 42887
Resolution FIXED
Resolved on Aug 23, 2019 02:51
Version unspecified
OS Linux
Blocks #41819
CC @zmodem

Extended Description

Currently, lld/COFF completely ignores /align option. That option is not required for building regular programs, but some programs such as device drivers needs it.

We need to handle that option correctly.

Discussion thread: http://lists.llvm.org/pipermail/llvm-dev/2019-August/134351.html

@rui314
Copy link
Member Author

rui314 commented Aug 5, 2019

Steven,

I created a patch for you. If you can build lld locally, can you apply this patch and try to see if this would fix your issue? https://reviews.llvm.org/D65736

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 5, 2019

Hi Rui,
Your patch works for me. Please help to check-in the patch. Thank you!

@llvmbot
Copy link
Collaborator

llvmbot commented Aug 23, 2019

Please add this /align support in LLVM 9.0.1 release, thanks!

@zmodem
Copy link
Collaborator

zmodem commented Aug 23, 2019

Please add this /align support in LLVM 9.0.1 release, thanks!

Rui's patch was committed in r368145 and I've merged it to the LLVM 9 branch in r369743.

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla lld:COFF
Projects
None yet
Development

No branches or pull requests

3 participants