readability-redundant-string-cstr quick-fix causes invalid code

[firewave]

Bugzilla Link	44620
Resolution	FIXED
Resolved on	Aug 27, 2020 06:00
Version	unspecified
OS	Windows NT
Blocks	#46070
CC	@f00kat,@zmodem,@hokein
Fixed by commit(s)	b99630e

Extended Description

#include

static void f2(std::string&&) {
}

static void f() {
std::string const s;
f2(s.c_str()); // readability-redundant-string-cstr warning
}

Applying the quick-fix to the code above causes it to fail as an rvalue is required.

[f00kat]

Hi

Which option is correct?

1. Check that "f2" argument declaration(std::string&&) isRValueReferenceType and do nothing. We will use the copy of c_str() in this case.
2. Fix with "f2(std::move(s))"

[llvmbot]

Drive by note, maybe this should explicitly create a copy of the string
f2(std::string(s))

[llvmbot]

Reopening this as a regression was introduced when fixing another bug, There is a patch in place to fix that regression https://reviews.llvm.org/D84831

[llvmbot]

Fixed again in b99630e, Will leave open for 11 branch merging as this regression was introduced on the 11 branch.

[zmodem]

Fixed again in
https://github.com/llvm/llvm-project/commit/
b99630e, Will leave open for 11 branch
merging as this regression was introduced on the 11 branch.

Pushed as b99630e

Please let me know if there are any further issues.

[hokein]

reopen this for cherry-pick eed0af6

[hokein]

oops, sorry, I changed a wrong bug.

[zmodem]

mentioned in issue #46070