Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 to 11.0 #46085

Closed
topperc opened this issue Jul 16, 2020 · 2 comments
Closed

Merge 00f3579aea6e3d4a4b7464c3db47294f71cef9e4 to 11.0 #46085

topperc opened this issue Jul 16, 2020 · 2 comments
Labels
bugzilla Issues migrated from bugzilla

Comments

@topperc
Copy link
Collaborator

topperc commented Jul 16, 2020

Bugzilla Link 46740
Resolution FIXED
Resolved on Jul 16, 2020 07:58
Version trunk
OS All
Blocks #46070
CC @zmodem

Extended Description

This reverts most of a 5 patch series due to reports of miscompiles.

The patches are
1cf6f21 [IR] Disable select ? C : undef -> C fold in ConstantFoldSelectInstruction unless we know C isn't poison.
469da66 [InstSimplify] Re-enable select ?, undef, X -> X transform when X is provably not poison
122b064 [InstSimplify] Don't fold vectors of partial undef in SimplifySelectInst if the non-undef element value might produce poison
ac0af12 [InstSimplify] Add test cases for opportunities to fold select ?, X, undef -> X when we can prove X isn't poison
9b1e953 [InstSimplify] Remove select ?, undef, X -> X and select ?, X, undef -> X transforms

Some of them added new test cases which I left but change the CHECK lines.

@topperc
Copy link
Collaborator Author

topperc commented Jul 16, 2020

Miscompile discussion is here https://reviews.llvm.org/D83360

@zmodem
Copy link
Collaborator

zmodem commented Jul 16, 2020

Pushed in 529f2e0. Thanks!

@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 10, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugzilla Issues migrated from bugzilla
Projects
None yet
Development

No branches or pull requests

2 participants