Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exegesis commit 8383fddc4fa9 breaks aarch64-windows-msvc build #48493

Closed
maxim-kuvyrkov opened this issue Feb 11, 2021 · 5 comments
Closed

Exegesis commit 8383fddc4fa9 breaks aarch64-windows-msvc build #48493

maxim-kuvyrkov opened this issue Feb 11, 2021 · 5 comments
Labels
bugzilla Issues migrated from bugzilla tools:llvm-exegesis

Comments

@maxim-kuvyrkov
Copy link
Contributor

Bugzilla Link 49149
Resolution FIXED
Resolved on Feb 16, 2021 16:52
Version trunk
OS All
Blocks #48246
CC @legrosbuffle,@gchatelet,@RKSimon,@tstellar
Fixed by commit(s) 06f53f2 d5d089b

Extended Description

Commit llvm-exegesis commit https://reviews.llvm.org/rG8383fddc4fa9b4e61954e5ac93b00719a39d2291 breaks build on aarch64-windows-msvc host.

X86-specific intrinsics are used under #ifdef _MSC_VER. With addition of Windows on Arm platform _MSC_VER no longer implied x86.

Proposed patch to fix this is at https://reviews.llvm.org/D96498 .
@RKSimon
Copy link
Collaborator

RKSimon commented Feb 12, 2021

Proposed patch to fix this is at https://reviews.llvm.org/D96498 .

This landed at 06f53f2

The request is to merge into 12.xxx once the fix has stewed in trunk for a few days.

@tstellar
Copy link
Collaborator

This has been in trunk for a few days, is it ready to backport?

@maxim-kuvyrkov
Copy link
Contributor Author

Yes, I'll cherry-pick to release/12.x today.

@maxim-kuvyrkov
Copy link
Contributor Author

Cherry-picked to release/12.x as d5d089b

@tstellar
Copy link
Collaborator

Merged: d5d089b

@tstellar tstellar mentioned this issue Jan 27, 2021
Closed
@llvmbot llvmbot transferred this issue from llvm/llvm-bugzilla-archive Dec 11, 2021
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bugzilla Issues migrated from bugzilla tools:llvm-exegesis
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tstellar @RKSimon @maxim-kuvyrkov