Support P1689 dependency format #51792
Assignees
Labels
bugzilla
Issues migrated from bugzilla
c++20
clang:modules
C++20 modules and Clang Header Modules
clang:tooling
LibTooling
Comments
|
Any update on this? Sorry to bump, but I've searched and couldn't find anything other than this issue regarding the support of P1689 on Clang. |
|
I've started plumbing the flags through and have them mostly working locally (the plumbing is laid down but there are clogs/hookups that need dealt with yet). However, there needs to be a new mode added to make the dependency mechanisms get the information necessary to where it can be output (that is, abusing FWIW, GCC is in the same boat for any header imports but name-only modules at least work there (with my patch). |
This was referenced Jul 28, 2022
|
May I ask if there is any update? Or if there is anything that other developers could help? |
|
@llvm/issue-subscribers-clang-modules |
CarlosAlbertoEnciso
pushed a commit
to SNSystems/llvm-debuginfo-analyzer
that referenced
this issue
Feb 10, 2023
… Named Modules in P1689 format (2/4) Close llvm/llvm-project#51792 Close llvm/llvm-project#56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
llvmbot
pushed a commit
to llvm/llvm-project-release-prs
that referenced
this issue
Feb 10, 2023
… Named Modules in P1689 format (2/4) Close llvm/llvm-project#51792 Close llvm/llvm-project#56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
ChuanqiXu9
added a commit
that referenced
this issue
Feb 13, 2023
…for C++20 Named Modules in P1689 format (2/4) Close #51792 Close #56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
ChuanqiXu9
added a commit
to ChuanqiXu9/llvm-project
that referenced
this issue
Feb 13, 2023
… Named Modules in P1689 format (2/4) Close llvm#51792 Close llvm#56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
CarlosAlbertoEnciso
pushed a commit
to SNSystems/llvm-debuginfo-analyzer
that referenced
this issue
Feb 13, 2023
…for C++20 Named Modules in P1689 format (2/4) Close llvm/llvm-project#51792 Close llvm/llvm-project#56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
tru
pushed a commit
to llvm/llvm-project-release-prs
that referenced
this issue
Feb 13, 2023
… Named Modules in P1689 format (2/4) Close llvm/llvm-project#51792 Close llvm/llvm-project#56770 This patch adds ClangScanDeps support for C++20 Named Modules in P1689 format. We can find the P1689 format at: https://www.open-std.org/jtc1/sc22/wg21/docs/papers/2022/p1689r5.html. After we land the patch, we're able to compile C++20 Named Modules with CMake! And although P1689 is written by kitware people, other build systems should be able to use the format to compile C++20 Named Modules too. TODO: Support header units in P1689 Format. TODO2: Support C++20 Modules in the full dependency format of ClangScanDeps. We also want to support C++20 Modules and clang modules together according to https://discourse.llvm.org/t/how-should-we-support-dependency-scanner-for-c-20-modules/66027. But P1689 format cares about C++20 Modules only for now. So let's focus on C++ Modules and P1689 format. And look at the full dependency format later. I'll add the ReleaseNotes and Documentations after the patch get landed. Reviewed By: jansvoboda11 Differential Revision: https://reviews.llvm.org/D137527
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Extended Description
Clang should support the P1689 dependency format for modules:
I have a patch to GCC (https://github.com/mathstuf/cxx-modules-sandbox/blob/docker/trtbd.diff) to submit that uses the following command line flags:
-fdep-format=The format to write dependency information out in. Currently, it usestrtbdwhich stands for "TR to be determined", but bikeshedding needs to commence at some point I suppose. Ideas:p1689,tr2222(the SG15 TR reserved number).-fdep-output=is the name of the primary output for the future compilation (the-othe real compile will see). This is analogous to-MT.-fdep-file=is the file to write the information to.The text was updated successfully, but these errors were encountered: