Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

windows release13.0.0: missing llvm-pdbutil in package #53461

Closed
yuanfang-chen opened this issue Jan 28, 2022 · 2 comments
Closed

windows release13.0.0: missing llvm-pdbutil in package #53461

yuanfang-chen opened this issue Jan 28, 2022 · 2 comments
Labels
packaging platform:windows

Comments

@yuanfang-chen
Copy link
Collaborator

No description provided.

@aganea
Copy link
Member

aganea commented Jan 29, 2022

Agreed, this is a bit annoying. @zmodem is this on intent?

@zmodem
Copy link
Collaborator

zmodem commented Jan 31, 2022

The intent is to include only "toolchain tools" (clang, lld, etc.) and not "llvm internal tools" (opt, llc, etc.).

I suppose for llvm-pdbutil the category isn't entirely clear. But I can see it's useful not just for llvm devs, so let's add it: https://reviews.llvm.org/D118606

@zmodem zmodem closed this as completed in db8ef94 Jan 31, 2022
arichardson pushed a commit to CTSRD-CHERI/llvm-project that referenced this issue Jan 3, 2023
@zmodem @arichardson
Add llvm-pdbutil in LLVM_TOOLCHAIN_TOOLS
6e51f8a 
One can argue that it qualifies as a toolchain tool rather than "internal llvm
tool". This will make it part of builds which set the
LLVM_INSTALL_TOOLCHAIN_ONLY cmake option, such as the Windows installer.

Fixes llvm/llvm-project#53461

Differential revision: https://reviews.llvm.org/D118606
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
packaging platform:windows
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@yuanfang-chen @zmodem @EugeneZelenko @aganea