[Attributor] Do not use liveness of the wrong function #53872
Assignees
Labels
Milestone
Comments
github-actions
bot
added
new issue
and removed
ipo
|
/cherry-pick 668c5c6 |
|
Failed to cherry-pick: 668c5c6 https://github.com/llvm/llvm-project/actions/runs/1855577960 Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:
|
|
/branch jdoerfert/llvm-project/issue53872 |
|
/pull-request llvmbot#81 |
|
@jdoerfert Can you rebase the issue53872 branch? The patches no longer apply cleanly. |
jdoerfert
added a commit
to jdoerfert/llvm-project
that referenced
this issue
Mar 2, 2022
When we use liveness for edges during the `genericValueTraversal` we need to make sure to use the AAIsDead of the correct function. This patch adds the proper logic and some simple caching scheme. We also add an assertion to the `isEdgeDead` call to make sure future misuse is detected earlier. Fixes llvm#53872
|
Done, I think. |
tstellar
pushed a commit
that referenced
this issue
Mar 2, 2022
When we use liveness for edges during the `genericValueTraversal` we need to make sure to use the AAIsDead of the correct function. This patch adds the proper logic and some simple caching scheme. We also add an assertion to the `isEdgeDead` call to make sure future misuse is detected earlier. Fixes #53872
|
Merged: a98c04d |
jdoerfert
added a commit
to jdoerfert/llvm-project
that referenced
this issue
Mar 25, 2022
When we use liveness for edges during the `genericValueTraversal` we need to make sure to use the AAIsDead of the correct function. This patch adds the proper logic and some simple caching scheme. We also add an assertion to the `isEdgeDead` call to make sure future misuse is detected earlier. Fixes llvm#53872
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
When we use liveness for edges during the `genericValueTraversal` we need to make sure to use the AAIsDead of the correct function. This patch adds the proper logic and some simple caching scheme. We also add an assertion to the `isEdgeDead` call to make sure future misuse is detected earlier. Fixes llvm/llvm-project#53872
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
If we use AAIsDead of the wrong function all queries will result in "is dead". This problem is at least present in the genericValueTraversal, could be other places too.
The text was updated successfully, but these errors were encountered: