FunctionOpInterface is incompatible with SingleBlock trait #54807
Labels
mlir:core
MLIR Core Infrastructure
Comments
|
@llvm/issue-subscribers-mlir-core |
mem-frob
pushed a commit
to draperlaboratory/hope-llvm-project
that referenced
this issue
Oct 7, 2022
Since the actual implementation class can arbitrarily shadow parts of the FunctionOpInterface exported API, access the body generically instead of via the use of the interface being defined. Fixes llvm/llvm-project#54807 Differential Revision: https://reviews.llvm.org/D123757
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The default implementation of
FunctionOpInterface::verifyBody()delegates to$_op.front(), but the interface methods of FunctionOpInterface may be shadowed in various ways making this illegal to assume. Concretely, theSingleBlocktrait definesfront()(and a number of other things) differently, resulting in ambiguous symbol resolution.This can be pretty easily fixed locally by accessing generically in the generated code:
Block &entryBlock = $_op->getRegion(0).front();but it is a shame that these APIs shadow each other in this way.The text was updated successfully, but these errors were encountered: