Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

symlink libclang.so.14 -> libclang.so.13 #54853

Closed
brooksdavis opened this issue Apr 11, 2022 · 5 comments
Closed

symlink libclang.so.14 -> libclang.so.13 #54853

brooksdavis opened this issue Apr 11, 2022 · 5 comments

Comments

@brooksdavis
Copy link
Contributor

The libclang.so version wasn't bumped in LLVM 14 due to a lack of ABI-breaking changes, but existing build systems sometimes assume a 1:1 correspondence between the LLVM major version and libclang's version. Adding a symlink would avoid needing to modify them.

@q66
Copy link
Contributor

q66 commented Apr 12, 2022

sounds like the existing build systems should be fixed then, doing this sounds absolutely wrong

@brooksdavis
Copy link
Contributor Author

I opened this issue at the request of @tstellar (https://discourse.llvm.org/t/llvm-14-0-1-schedule-and-release-updates/61227/18?u=brooks). I'm proceeding with adding the link to the FreeBSD package as part of 14.0.1.

See also #54004

@kloczek
Copy link

kloczek commented Apr 21, 2022

Someone solved taht alredy? 🤔

@MaskRay
Copy link
Member

MaskRay commented Apr 22, 2022

I agree with q66 that this is downstream build system bug. I'd prefer llvm-project does not add more complexity. The downstream should be fixed.

libclang.so.$major the version number being predictable so far does not necessarily mean we provide guarantee. Fixing downstream will give more flexibility to llvm-project.

@brooksdavis
Copy link
Contributor Author

Later releases stopped doing this so it's OBE.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants