New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[X86] bt regression with bmi #55138
Labels
Comments
Didn't verify, but I think it's changed by https://reviews.llvm.org/D122891 |
My mistake, bmi is better https://godbolt.org/z/rWj8bn8j6 |
@llvm/issue-subscribers-backend-x86 |
RKSimon
added a commit
that referenced
this issue
Apr 27, 2022
RKSimon
added a commit
that referenced
this issue
Apr 27, 2022
As discussed on Issue #55138 - BMI2 (fast shrx) shouldn't always fold to BT
RKSimon
added a commit
that referenced
this issue
Apr 28, 2022
Ideally we'd fold this with generic DAGCombiner, but that only works for !isTruncateFree cases - we might be able to adapt IsDesirableToPromoteOp to find truncated src ops in the future, but for now just use this peephole. Noticed in Issue #55138
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
looks worse with bmi?
godbolt: https://godbolt.org/z/aj3so3noj
trunk:
clang 14:
clang 14 with bmi2:
The text was updated successfully, but these errors were encountered: