New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc++: source_location not implemented #56363

Closed

jgcodes2020 opened this issue Jul 3, 2022 · 1 comment

Labels

libc++

jgcodes2020 commented Jul 3, 2022

Most of the implementation is trivial, and I'd like to submit a PR for it. However, there are two approaches to std::source_location::current():

std::source_location::current() has 4 default arguments set to __builtin_FILE(), etc.
builtins are added that return the call site of the function that called std::source_location::current()

I'd like to see an answer from developers working on libc++ before I consider submitting.

The text was updated successfully, but these errors were encountered:

github-actions bot added the new issue label

EugeneZelenko added libc++ and removed new issue labels

Contributor

philnik777 commented Jul 3, 2022

There is https://reviews.llvm.org/D120634 already. It will most likely be part of LLVM 15.

jyknight closed this as completed in

73d94b1

CarlosAlbertoEnciso pushed a commit to SNSystems/llvm-debuginfo-analyzer that referenced this issue


          [Libcxx] Add <source_location> header.

This requires the __builtin_source_location() builtin, as implemented
by GCC and Clang.

Fixes llvm/llvm-project#56363

Differential Revision: https://reviews.llvm.org/D120634

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment