[compiler-rt] error: multiple definition of 'enum fsconfig_command' #56421

andreas-schwab · 2022-07-07T09:39:25Z

libsanitizer fails to build with the very latest glibc:

In file included from /usr/include/linux/fs.h:19,
                 from ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:76:
/usr/include/linux/mount.h:95:6: error: multiple definition of 'enum fsconfig_command'
   95 | enum fsconfig_command {
      |      ^~~~~~~~~~~~~~~~
In file included from ../../../../libsanitizer/sanitizer_common/sanitizer_platform_limits_posix.cpp:63:
/usr/include/sys/mount.h:189:6: note: previous definition here
  189 | enum fsconfig_command
      |      ^~~~~~~~~~~~~~~~
/usr/include/linux/mount.h:129:8: error: redefinition of 'struct mount_attr'
  129 | struct mount_attr {
      |        ^~~~~~~~~~
/usr/include/sys/mount.h:161:8: note: previous definition of 'struct mount_attr'
  161 | struct mount_attr
      |        ^~~~~~~~~~

MaskRay · 2022-07-11T06:27:20Z

Can you share detailed reproduce instructions?

I have built latest glibc in /tmp/glibc/lld/ and latest kernel headers for userspace in /tmp/linux/x86_64 (make O=/tmp/linux/x86_64 -j60 headers_install).

With cmake -DLLVM_ENABLE_PROJECTS='clang;compiler-rt' -DLLVM_TARGETS_TO_BUILD='X86' -DCMAKE_{C,CXX}_FLAGS='-isystem/tmp/glibc/lld/include -isystem/tmp/linux/x86_64/usr/include', ninja asan reproduces the error.

The sanitizer_common/sanitizer_platform_limits_posix.cpp compile uses

. /tmp/glibc/lld/include/sys/mount.h
.. /tmp/linux/x86_64/usr/include/linux/mount.h

glibc 7eae6a91e9b1670330c9f15730082c91c0b1d570 triggered this.

MaskRay · 2022-07-11T08:11:06Z

Patch: https://reviews.llvm.org/D129471

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Android sys/mount.h doesn't define BLKBSZGET and it still needs linux/fs.h. In the long term we should move Linux specific definitions to sanitizer_platform_limits_linux.cpp but this commit is easy to cherry pick into older compiler-rt releases. Fix #56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471

MaskRay · 2022-07-11T20:42:49Z

9cf1306 is the commit to cherry pick into older compiler-rt if you want to build those packages on glibc 2.36 (will be released soon in 2022-08).

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Android sys/mount.h doesn't define BLKBSZGET and it still needs linux/fs.h. In the long term we should move Linux specific definitions to sanitizer_platform_limits_linux.cpp but this commit is easy to cherry pick into older compiler-rt releases. Fix llvm#56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471 Signed-off-by: Khem Raj <raj.khem@gmail.com>

marxin · 2022-08-08T08:35:52Z

Can you please cherry-pick the commit for LLVM 14 branch?

EugeneZelenko · 2022-08-08T13:38:17Z

@marxin: 14 branch is not longer supported.

marxin · 2022-08-08T14:00:03Z

Hm, but version 15 hasn't been released yet, right?

EugeneZelenko · 2022-08-08T14:06:23Z

Fixes are backported to 15.

marxin · 2022-08-08T18:35:43Z

Fixes are backported to 15.

But why don't you have an overlap in between supported branches? Note that right now, there is no stable LLVM release that would contain this change and so that can co-exist with glibc 2.39. Sigh.

AaronBallman · 2022-08-15T11:45:28Z

CC @tstellar for questions about release branch processes.

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Fix llvm/llvm-project#56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Android sys/mount.h doesn't define BLKBSZGET and it still needs linux/fs.h. In the long term we should move Linux specific definitions to sanitizer_platform_limits_linux.cpp but this commit is easy to cherry pick into older compiler-rt releases. Fix llvm/llvm-project#56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Fix llvm/llvm-project#56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471

…mount_attr conflict with glibc 2.36 It is generally not a good idea to mix usage of glibc headers and Linux UAPI headers (https://sourceware.org/glibc/wiki/Synchronizing_Headers). In glibc since 7eae6a91e9b1670330c9f15730082c91c0b1d570 (milestone: 2.36), sys/mount.h defines `fsconfig_command` which conflicts with linux/mount.h: .../usr/include/linux/mount.h:95:6: error: redeclaration of ‘enum fsconfig_command’ Remove #include <linux/fs.h> which pulls in linux/mount.h. Expand its 4 macros manually. Android sys/mount.h doesn't define BLKBSZGET and it still needs linux/fs.h. In the long term we should move Linux specific definitions to sanitizer_platform_limits_linux.cpp but this commit is easy to cherry pick into older compiler-rt releases. Fix llvm/llvm-project#56421 Reviewed By: #sanitizers, vitalybuka, zatrazz Differential Revision: https://reviews.llvm.org/D129471

When compiling older GCC versions in newer machines, libsanitizer does not compile, showing a error: `multiple definition of 'enum fsconfig_command'` (e.g. llvm/llvm-project#56421). This is because starting from Glibc 2.36, it is not possible to include both "linux/fs.h" and "sys/mount.h". We can apply a patch, similar to the one in https://reviews.llvm.org/D129471 , but with the extension and lines changed to match the file. This is also similar to the upstream fix.

When compiling older GCC versions in newer machines, libsanitizer does not compile, showing a error: `multiple definition of 'enum fsconfig_command'` (e.g. llvm/llvm-project#56421). This is because starting from Glibc 2.36, it is not possible to include both "linux/fs.h" and "sys/mount.h". We can apply a patch, similar to the one in https://reviews.llvm.org/D129471 , but with the extension and lines changed to match the file. This is also similar to the upstream fix. See merge request nexedi/slapos!1579

github-actions bot added the new issue label Jul 7, 2022

EugeneZelenko added compiler-rt build-problem and removed new issue labels Jul 7, 2022

dkm mentioned this issue Jul 9, 2022

Cleanup docker image, add helper scripts and add more GCC 12.1.0 compiler-explorer/gcc-cross-builder#30

Merged

MaskRay closed this as completed in b379129 Jul 11, 2022

MaskRay self-assigned this Jul 11, 2022

cuviper mentioned this issue Aug 11, 2022

llvm build failure rust-lang/rust#100357

Closed

landley mentioned this issue Aug 13, 2022

linux filesystem conflict with glibc >=2.36 landley/toybox#362

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[compiler-rt] error: multiple definition of 'enum fsconfig_command' #56421

[compiler-rt] error: multiple definition of 'enum fsconfig_command' #56421

andreas-schwab commented Jul 7, 2022 •

edited by VoltrexKeyva

Loading

MaskRay commented Jul 11, 2022 •

edited

Loading

MaskRay commented Jul 11, 2022

MaskRay commented Jul 11, 2022

marxin commented Aug 8, 2022

EugeneZelenko commented Aug 8, 2022

marxin commented Aug 8, 2022

EugeneZelenko commented Aug 8, 2022

marxin commented Aug 8, 2022

AaronBallman commented Aug 15, 2022

[compiler-rt] error: multiple definition of 'enum fsconfig_command' #56421

[compiler-rt] error: multiple definition of 'enum fsconfig_command' #56421

Comments

andreas-schwab commented Jul 7, 2022 • edited by VoltrexKeyva Loading

MaskRay commented Jul 11, 2022 • edited Loading

MaskRay commented Jul 11, 2022

MaskRay commented Jul 11, 2022

marxin commented Aug 8, 2022

EugeneZelenko commented Aug 8, 2022

marxin commented Aug 8, 2022

EugeneZelenko commented Aug 8, 2022

marxin commented Aug 8, 2022

AaronBallman commented Aug 15, 2022

andreas-schwab commented Jul 7, 2022 •

edited by VoltrexKeyva

Loading

MaskRay commented Jul 11, 2022 •

edited

Loading