[mlir] Lit tests fail after BF16 ABI change #57042
Comments
|
@llvm/issue-subscribers-mlir |
|
The ABI issue was supposed to be fixed by https://reviews.llvm.org/D128018 which passes the value through memory (by reference rather than by value). If it breaks again I really would like to know why and not disable the tests anymore. |
|
Discussed this with @joker-eph. For the sake of progress, I am okay disabling the tests and investigating what happened "offline". |
Supposedly our ABI issues were fixed, per issue: #55992 However, with a recent changes to bf16, these tests fail again; not sure why yet: https://reviews.llvm.org/D130832 https://lab.llvm.org/buildbot/#/builders/61/builds/30600 So we disable the tests for now. Issue is tracked in: #57042 Differential Revision: https://reviews.llvm.org/D131621
|
Thanks @joker-eph and @aartbik . I think the problem is in the runtimes that still expect BF16 type passed as |
|
FYI. This is what I changed in compiler-rt https://reviews.llvm.org/D131147 |
Supposedly our ABI issues were fixed, per issue: llvm/llvm-project#55992 However, with a recent changes to bf16, these tests fail again; not sure why yet: https://reviews.llvm.org/D130832 https://lab.llvm.org/buildbot/#/builders/61/builds/30600 So we disable the tests for now. Issue is tracked in: llvm/llvm-project#57042 Differential Revision: https://reviews.llvm.org/D131621 (cherry picked from commit 6b74591)
|
@llvm/issue-subscribers-mlir-sparse |
Supposedly our ABI issues were fixed, per issue: llvm/llvm-project#55992 However, with a recent changes to bf16, these tests fail again; not sure why yet: https://reviews.llvm.org/D130832 https://lab.llvm.org/buildbot/#/builders/61/builds/30600 So we disable the tests for now. Issue is tracked in: llvm/llvm-project#57042 Differential Revision: https://reviews.llvm.org/D131621 (cherry picked from commit 6b74591)
Supposedly our ABI issues were fixed, per issue: llvm/llvm-project#55992 However, with a recent changes to bf16, these tests fail again; not sure why yet: https://reviews.llvm.org/D130832 https://lab.llvm.org/buildbot/#/builders/61/builds/30600 So we disable the tests for now. Issue is tracked in: llvm/llvm-project#57042 Differential Revision: https://reviews.llvm.org/D131621 (cherry picked from commit 6b74591)
c7ec6e1 made LLVM adhere to the x86 psABI and pass bf16 in SSE registers instead of GPRs. This breaks the custom versions of runtime functions we have for bf16 conversion. A great fix for this would be to use __bf16 types instead which carry the right ABI, but that type isn't widely available. Instead just pretend it's a 32 bit float on the ABI boundary and carefully cast it to the right type. Fixes #57042 (cherry picked from commit f695554)
Supposedly our ABI issues were fixed, per issue: llvm/llvm-project#55992 However, with a recent changes to bf16, these tests fail again; not sure why yet: https://reviews.llvm.org/D130832 https://lab.llvm.org/buildbot/#/builders/61/builds/30600 So we disable the tests for now. Issue is tracked in: llvm/llvm-project#57042 Differential Revision: https://reviews.llvm.org/D131621 (cherry picked from commit 6b7459115f7b1c43f81ad8dfb5da9d206d3b1e06)
I had a patch c7ec6e1 to make the
bfloattype to follow X86 psABI. It seems the change makes MLIR tests failed again:I suppose it is the same reason as #55992. cc @joker-eph @aartbik do I need to disable them temporarily, or you have a quick fix? Please notice, I'm planning to backport the change to LLVM 15.0 too.
The text was updated successfully, but these errors were encountered: