Make Definition Block Spacing Configurable #57180
Assignees
Labels
Comments
|
@llvm/issue-subscribers-clang-format |
codeinred
added a commit
to codeinred/llvm-project
that referenced
this issue
Aug 17, 2022
Fixes llvm#57180 Given configuration: ``` SeparateDefinitionBlocks: Always DefinitionBlockSpacing: 2 ``` Two spaces will be inserted between definition blocks. Code before formatting: ``` /// f is a function void f() { // Some code // More code return; } /// g is another function void g() { // Some other code } ``` Versus code after formatting: ``` /// f is a function void f() { // Some code // More code return; } /// g is another function void g() { // Some other code } ``` Note: two zero width spaces were inserted into the commit message in order to prevent git from removing the additional lines inside the commit. These will not appear in formatted code.
|
Update: I've implemented this feature here. I'll be submitting this patch for review. |
|
Update: Patch submitted for review: https://reviews.llvm.org/D132256 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
As it currently exists, the
SeparateDefinitionBlocksoption only allows for no spacing (SDS_Never), or exactly one space (SDS_Always). The amount of space should be configurable, especially as some organizations require two spaces between blocks as part of their formatting style.In the ideal case, an option such as
DefinitionBlockSpacingwould be added to allow users to set a custom amount of space between definition blocks. For example,Would result in two lines being used to separate definition blocks.
The text was updated successfully, but these errors were encountered: