Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Main fails to build on export called with target "clangdRemoteIndex" which requires target #57213

Closed
sylvestre opened this issue Aug 18, 2022 · 3 comments
Closed

Main fails to build on export called with target "clangdRemoteIndex" which requires target #57213

sylvestre opened this issue Aug 18, 2022 · 3 comments
Labels
build-problem clangd cmake Build system in general and CMake in particular

Comments

@sylvestre
Copy link
Collaborator

sylvestre commented Aug 18, 2022 •
edited by VoltrexKeyva

with stage2

-- Performing Test HAVE_STEADY_CLOCK
-- Performing Test HAVE_STEADY_CLOCK -- success
-- Configuring done
CMake Error: install(EXPORT "ClangTargets" ...) includes target "clangdRemoteIndex" which requires target "clangdRemoteIndexProto" that is not in any export set.
CMake Error: install(EXPORT "ClangTargets" ...) includes target "clangdRemoteIndex" which requires target "clangdRemoteIndexServiceProto" that is not in any export set.
CMake Error: install(EXPORT "ClangTargets" ...) includes target "clangdRemoteMarshalling" which requires target "clangdRemoteIndexProto" that is not in any export set.
CMake Error in /build/llvm-toolchain-snapshot-16~++20220818071835+ed342d9d2989/clang/cmake/modules/CMakeLists.txt:
  export called with target "clangdRemoteIndex" which requires target
  "clangdRemoteIndexProto" that is not in any export set.


CMake Error in /build/llvm-toolchain-snapshot-16~++20220818071835+ed342d9d2989/clang/cmake/modules/CMakeLists.txt:
  export called with target "clangdRemoteIndex" which requires target
  "clangdRemoteIndexServiceProto" that is not in any export set.


CMake Error in /build/llvm-toolchain-snapshot-16~++20220818071835+ed342d9d2989/clang/cmake/modules/CMakeLists.txt:
  export called with target "clangdRemoteMarshalling" which requires target
  "clangdRemoteIndexProto" that is not in any export set.

Full log:
https://llvm-jenkins.debian.net/job/llvm-toolchain-bullseye-binaries/architecture=amd64,distribution=bullseye,label=amd64/297/consoleFull
@i-ky i-ky mentioned this issue Aug 18, 2022
Closed
@sam-mccall
Copy link
Collaborator

The trigger seems to be ba68802, which is a follow up to
cae7658 trying to untangle FindGRPC.cmake.

Unfortunately I don't really understand what the exports do, thus the optimistic/maybe-premature approval of the original patch.

So I think I need to leave this to @akyrtzi @cachemeifyoucan to decide whether to revert the last patch or both together, or whether there's a good fix forward.

Simple repro from clangd/clangd#1255:

cmake ~/llvm-project/llvm/ -DCMAKE_BUILD_TYPE=Release -DLLVM_ENABLE_PROJECTS="clang;clang-tools-extra" -DCLANGD_ENABLE_REMOTE=On -G Ninja

(fails at generation time with the same error)

@akyrtzi
Copy link
Contributor

akyrtzi commented Aug 18, 2022

Sorry about that, reverting my follow-up here: https://reviews.llvm.org/D132138

akyrtzi added a commit that referenced this issue Aug 18, 2022
@akyrtzi
Revert "[FindGRPC.cmake] Use llvm_add_library() for the custom prot…
dd8982d 
…o target instead of `add_llvm_library()`"

Breaks configuring `clangd` with `-DCLANGD_ENABLE_REMOTE=On` (#57213)

This reverts commit ba68802.

Differential Revision: https://reviews.llvm.org/D132138
@akyrtzi akyrtzi closed this as completed Aug 18, 2022
@sylvestre
Copy link
Collaborator Author

sylvestre commented Aug 18, 2022 via email

@EugeneZelenko EugeneZelenko added the cmake Build system in general and CMake in particular label Aug 18, 2022
thilinarmtb pushed a commit to nomp-org/llvm-project that referenced this issue Aug 24, 2022
@akyrtzi @thilinarmtb
Revert "[FindGRPC.cmake] Use llvm_add_library() for the custom prot…
a837cf0 
…o target instead of `add_llvm_library()`"

Breaks configuring `clangd` with `-DCLANGD_ENABLE_REMOTE=On` (llvm/llvm-project#57213)

This reverts commit ba68802.

Differential Revision: https://reviews.llvm.org/D132138
akyrtzi added a commit to apple/llvm-project that referenced this issue Oct 2, 2022
@akyrtzi
Revert "[FindGRPC.cmake] Use llvm_add_library() for the custom prot…
bfb5dbe 
…o target instead of `add_llvm_library()`"

Breaks configuring `clangd` with `-DCLANGD_ENABLE_REMOTE=On` (llvm#57213)

This reverts commit ba68802.

Differential Revision: https://reviews.llvm.org/D132138

(cherry picked from commit dd8982d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
build-problem clangd cmake Build system in general and CMake in particular
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@akyrtzi @sam-mccall @sylvestre @EugeneZelenko