ld.lld crashing when linking Gimp 3 (2.99) #57243
Comments
EugeneZelenko
added
lld:COFF
crash
|
@llvm/issue-subscribers-lld-coff |
|
For anyone to be able to reproduce it (without doing the same full build and hoping to trigger the same cases) - can you rerun the linking command with |
|
Here The issue happens in the very last end of the build when linking the main gimp executable. |
|
Thanks! I've managed to reproduce the issue, and I understand what's going on. (The problem is that |
|
The fix suggestion is in https://reviews.llvm.org/D132361. Headsup @tru @tstellar - this fix would be nice to get into the 15.x release too (once it passes review), if we're not too late for that. |
|
As long as the fix lands within two weeks it can go into the final 15.0.0. Otherwise it will have to wait until 15.0.1. |
|
@mstorsjo What's the status of this? RC3 is just about to be tagged and I will be very hesitant to take anything after that unless it's really critical. |
I've updated https://reviews.llvm.org/D132361 according to @rnk's suggestion, but he hasn't had time to re-review it yet (although I don't foresee him having further comments on it after that). But apparently @mati865 just did approve it, so I guess I could land it and file the backport request. |
|
Reopening for backport to 15.x |
|
/cherry-pick af39e6f |
|
/branch llvm/llvm-project-release-prs/issue57243 |
When an object file contains an export directive, we normally do some amount of deferred processing of them at the end of the linking process. The -includeoptional option was handled after this, and any object files (defining new exports) weren't handled. Move the handling of the -includeoptional into the same late loop which does the fixups for e.g. export directives. Ideally, this would also be done for object files that are pulled in by the wrap options, and for mingw autoimports, but those changes require more modifications, to make them safe for potentially being executed multiple times. This fixes llvm/llvm-project#57243. Differential Revision: https://reviews.llvm.org/D132361 (cherry picked from commit af39e6f)
|
/pull-request llvm/llvm-project-release-prs#129 |
When an object file contains an export directive, we normally do some amount of deferred processing of them at the end of the linking process. The -includeoptional option was handled after this, and any object files (defining new exports) weren't handled. Move the handling of the -includeoptional into the same late loop which does the fixups for e.g. export directives. Ideally, this would also be done for object files that are pulled in by the wrap options, and for mingw autoimports, but those changes require more modifications, to make them safe for potentially being executed multiple times. This fixes llvm/llvm-project#57243. Differential Revision: https://reviews.llvm.org/D132361 (cherry picked from commit af39e6f)
When an object file contains an export directive, we normally do some amount of deferred processing of them at the end of the linking process. The -includeoptional option was handled after this, and any object files (defining new exports) weren't handled. Move the handling of the -includeoptional into the same late loop which does the fixups for e.g. export directives. Ideally, this would also be done for object files that are pulled in by the wrap options, and for mingw autoimports, but those changes require more modifications, to make them safe for potentially being executed multiple times. This fixes llvm/llvm-project#57243. Differential Revision: https://reviews.llvm.org/D132361 (cherry picked from commit af39e6f6fc905f3c067f022fb44136779d2f9c84)
With Clang 14.0.6 from Mingw64/MSYS2
The text was updated successfully, but these errors were encountered: