Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[IR] Add alignment for @llvm.threadlocal.address #57438

Closed
ChuanqiXu9 opened this issue Aug 30, 2022 · 2 comments
Closed

[IR] Add alignment for @llvm.threadlocal.address #57438

ChuanqiXu9 opened this issue Aug 30, 2022 · 2 comments
Labels
llvm:core

Comments

@ChuanqiXu9
Copy link
Member

See https://reviews.llvm.org/D129833 for the reason.

Simply, we introduced @llvm.threadlocal.address to replace the direct use of TLS globals. However, we missed the alignment property after this transition. We need complete it.
@alexander-shaposhnikov
Copy link
Collaborator

I've prepared a patch, planning to send it for review ~soon.

@ChuanqiXu9
Copy link
Member Author

I've prepared a patch, planning to send it for review ~soon.

Oh, thanks! I was too busy to delay this.

alexander-shaposhnikov added a commit that referenced this issue Sep 13, 2022
@alexander-shaposhnikov
[IR] Add alignment for llvm.threadlocal.address
b6965f7 
This diff sets the alignment attribute for the return value
and the argument of llvm.threadlocal.address.

(#57438)

Test plan: ninja check-all

Differential revision: https://reviews.llvm.org/D133741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
llvm:core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@alexander-shaposhnikov @ChuanqiXu9