Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b #57802

Closed
pkubaj opened this issue Sep 17, 2022 · 8 comments
Closed

fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b #57802

pkubaj opened this issue Sep 17, 2022 · 8 comments
Assignees
@MaskRay
Labels
backend:AArch64 backend:ARM

Comments

@pkubaj
Copy link
Contributor

pkubaj commented Sep 17, 2022 •
edited by VoltrexKeyva
Loading

llvm 16.0.0 from FreeBSD`s llvm-devel-16.0.d20220906 package
FreeBSD 13.1-RELEASE
armv7

Run:

clang-devel -cc1 -triple armv7-unknown-freebsd13.1-gnueabihf -emit-obj 7zCrc-50d52a.c

7zCrc-50d52a.c:

int a, b;
int d() {
  return __builtin_arm_crc32b(a, b);
}

Output:

fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 17, 2022

@llvm/issue-subscribers-backend-arm

@MaskRay MaskRay self-assigned this Sep 18, 2022
@MaskRay
Copy link
Member

MaskRay commented Sep 18, 2022

Patch: https://reviews.llvm.org/D134127

@stefson
Copy link

stefson commented Sep 18, 2022

I just reproduced this with clang-14 for armv7-unknown-linux-gnueabihf, so can you please consider to backport the fix to all supported branches?

@EugeneZelenko
Copy link
Contributor

@stefson: Only 15 is supported.

@stefson
Copy link

stefson commented Sep 19, 2022

if llvm-15 is all supported branches, I take it (:

@MaskRay
Copy link
Member

MaskRay commented Sep 19, 2022 •
edited
Loading

I just reproduced this with clang-14 for armv7-unknown-linux-gnueabihf, so can you please consider to backport the fix to all supported branches?

This clang crash (SelectionDAG fails to select an instruction) usually doesn't matter because users are supposed to include arm_acle.h and use __crc32* instead of the underlying __builtin_arm_crc32*. arm_acle.h uses #ifdef __ARM_FEATURE_CRC32, so the issue won't manifest.

@davemgreen
Copy link
Collaborator

Good stuff. We should reopen this to make sure the AArch64 equivalent happens too, it should be a very similar patch.
https://godbolt.org/z/oMnonzP8o

@davemgreen davemgreen reopened this Sep 22, 2022
@llvmbot
Copy link
Collaborator

llvmbot commented Sep 22, 2022

@llvm/issue-subscribers-backend-aarch64

freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue May 29, 2023
@DimitryAndric
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
8792c03 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days
hardenedbsd-services pushed a commit to HardenedBSD/hardenedBSD that referenced this issue May 30, 2023
@DimitryAndric @lattera
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
55dbe25 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days
freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue Jun 1, 2023
@DimitryAndric
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
dbbac83 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days

(cherry picked from commit 8792c03)
freebsd-git pushed a commit to freebsd/freebsd-src that referenced this issue Jun 1, 2023
@DimitryAndric
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
3cc4f10 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days

(cherry picked from commit 8792c03)
laffer1 pushed a commit to MidnightBSD/src that referenced this issue Jun 27, 2023
@DimitryAndric @laffer1
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
8a1e555 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days

(cherry picked from commit 8792c03886d9e6df10fbac825819603dc059c7ea)
bsdjhb pushed a commit to bsdjhb/cheribsd that referenced this issue Aug 11, 2023
@DimitryAndric @bsdjhb
Apply clang fixes for crashes compiling ARM/AArch64 CRC intrinsics
cbf9ae8 
Merge commit 069ecd0c6e2c from llvm-project (by Fangrui Song):

  [ARM] Check target feature support for __builtin_arm_crc*

  `__builtin_arm_crc*` requires the target feature crc which is available on armv8
  and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

  ```
  % clang -c --target=armv7-unknown-linux-gnueabi -c a.c
  fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
  PLEASE submit a bug report to ...
  ```

  Add `TARGET_BUILTIN` and define required features for these builtins to
  report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
  I will add `TARGET_BUILTIN` for more builtins later.

  Fix llvm/llvm-project#57802

  Differential Revision: https://reviews.llvm.org/D134127

Merge commit b2d7a0dcf1ff from llvm-project (by Fangrui Song):

  [AArch64] Check target feature support for __builtin_arm_crc*

  This is the AArch64 counterpart of D134127.
  Daniel Kiss will change more `BUILTIN` to `TARGET_BUILTIN`.

  Fix #57802

Note that programs attempting to use ARM/AArch64 CRC intrinsics, when
they are not supported by the targeted CPU, will still receive a regular
compilation error (instead of a fatal backend error) similar to:

  7zCrc.c:4:10: error: '__builtin_arm_crc32b' needs target feature crc
    return __builtin_arm_crc32b(a, b);
           ^

Reported by:	Alastair Hogge <agh@riseup.net>
PR:		271624
MFC after:	3 days
veselypeta pushed a commit to veselypeta/cherillvm that referenced this issue May 20, 2024
@MaskRay
[ARM] Check target feature support for __builtin_arm_crc*
7b8bc61 
`__builtin_arm_crc*` requires the target feature crc which is available on armv8
and above. Calling the fuctions for armv7 leads to a SelectionDAG crash.

```
% clang -c --target=armv7-unknown-linux-gnueabi -c a.c
fatal error: error in backend: Cannot select: intrinsic %llvm.arm.crc32b
PLEASE submit a bug report to ...
```

Add `TARGET_BUILTIN` and define required features for these builtins to
report an error in `CodeGenFunction::checkTargetFeatures`. The problem is quite widespread.
I will add `TARGET_BUILTIN` for more builtins later.

Fix llvm/llvm-project#57802

Differential Revision: https://reviews.llvm.org/D134127
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MaskRay MaskRay

Labels
backend:AArch64 backend:ARM
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@MaskRay @pkubaj @EugeneZelenko @davemgreen @stefson @llvmbot