Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Review, refactor, and possibly remove the IR interpreter #58086

Open
lhames opened this issue Sep 30, 2022 · 0 comments
Open

Review, refactor, and possibly remove the IR interpreter #58086

lhames opened this issue Sep 30, 2022 · 0 comments
Labels
mcjit

Comments

@lhames
Copy link
Contributor

lhames commented Sep 30, 2022

Reviewing ExternalSymbols.cpp, some of this code is over twenty years old and contains calls to unsafe string functions.

The interpreter should be reviewed and either refactored to be more memory safe, or removed entirely (it's not clear who's using it, or if it's being used at all).
@lhames lhames added mcjit and removed new issue labels Sep 30, 2022
lhames added a commit that referenced this issue Mar 1, 2023
@lhames
[ExecutionEngine] Silence warnings about sprintf use in interpreter.
0963833 
We should review memory safety in the interpreter
(#58086), but for now just silence
the warnings to reduce noise.

rdar://100555195
akiramenai pushed a commit to matter-labs/era-compiler-llvm that referenced this issue Aug 25, 2023
@lhames @akiramenai
[ExecutionEngine] Silence warnings about sprintf use in interpreter.
ec2110a 
We should review memory safety in the interpreter
(llvm/llvm-project#58086), but for now just silence
the warnings to reduce noise.

rdar://100555195
akiramenai pushed a commit to matter-labs/era-compiler-llvm that referenced this issue Aug 26, 2023
@lhames @akiramenai
[ExecutionEngine] Silence warnings about sprintf use in interpreter.
8c17ea9 
We should review memory safety in the interpreter
(llvm/llvm-project#58086), but for now just silence
the warnings to reduce noise.

rdar://100555195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
mcjit
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@lhames