Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OpenMP] New test (bug54082.c) failure on Windows #60326

Closed
shiltian opened this issue Jan 27, 2023 · 8 comments · Fixed by llvm/llvm-project-release-prs#241
Closed

[OpenMP] New test (bug54082.c) failure on Windows #60326

shiltian opened this issue Jan 27, 2023 · 8 comments · Fixed by llvm/llvm-project-release-prs#241
Assignees
@shiltian
Labels
openmp platform:windows release:backport release:merged
Milestone
LLVM 16.0.0 Release

Comments

@shiltian
Copy link
Contributor

https://reviews.llvm.org/D142297 introduced new test failure on Windows. It will be fixed in https://reviews.llvm.org/D142684. After it is merged, this has to be back ported to release branch.
@shiltian shiltian self-assigned this Jan 27, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2023

@llvm/issue-subscribers-openmp

@shiltian shiltian reopened this Jan 27, 2023
@shiltian
Copy link
Contributor Author

/cherry-pick 544f8c7

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2023

/cherry-pick 544f8c7

Error: Command failed due to missing milestone.

@shiltian shiltian added this to the LLVM 16.0.0 Release milestone Jan 27, 2023
@shiltian
Copy link
Contributor Author

/cherry-pick 544f8c7

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2023

Failed to cherry-pick: 544f8c7

https://github.com/llvm/llvm-project/actions/runs/4021714616

Please manually backport the fix and push it to your github fork. Once this is done, please add a comment like this:

/branch <user>/<repo>/<branch>

@mstorsjo
Copy link
Member

/cherry-pick 544f8c7

@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2023

/branch llvm/llvm-project-release-prs/issue60326

@llvmbot llvmbot mentioned this issue Jan 27, 2023
Merged
@llvmbot
Copy link
Collaborator

llvmbot commented Jan 27, 2023

/pull-request llvm/llvm-project-release-prs#241

tru pushed a commit that referenced this issue Jan 27, 2023
@shiltian @tru
[OpenMP] Fix stack overflow for test bug54082.c
1639161 
When `N` is 1024, `int result[N][N]` is obviously large stack that Windows cannot support...

Fix #60326.

Reviewed By: jdoerfert

Differential Revision: https://reviews.llvm.org/D142684

(cherry picked from commit 544f8c7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shiltian shiltian

Labels
openmp platform:windows release:backport release:merged
Projects
LLVM Release Status
Archived in project
Milestone
LLVM 16.0.0 Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#60326 llvm/llvm-project-release-prs
4 participants
@mstorsjo @shiltian @EugeneZelenko @llvmbot