[AMDGPU][AsmParser] Refine parsing instructions #62629
Assignees
Labels
Comments
|
@llvm/issue-subscribers-backend-amdgpu |
kosarev
added a commit
that referenced
this issue
May 19, 2023
Eliminates the need for the custom code in parseCustomOperand(). The remaining uses of NamedOperandU32 are to be addressed separately. Part of <#62629>. Reviewed By: dp Differential Revision: https://reviews.llvm.org/D150204
kosarev
added a commit
that referenced
this issue
May 29, 2023
Eliminates the need for the custom code in parseCustomOperand(). Part of <#62629>. Reviewed By: dp Differential Revision: https://reviews.llvm.org/D150980
kosarev
added a commit
that referenced
this issue
Jun 5, 2023
…tom operands. Removes unnecessary duplication in TableGen definitions. Part of <#62629>. Reviewed By: dp Differential Revision: https://reviews.llvm.org/D151684
kosarev
added a commit
that referenced
this issue
Jun 5, 2023
…lasses. Eliminates the need for custom operand classes whose only purpose is to define a parser method. Part of <#62629>. Reviewed By: dp Differential Revision: https://reviews.llvm.org/D151685
kosarev
added a commit
that referenced
this issue
Jun 13, 2023
Clears the road to eliminating custom default operand handlers. Also unifies naming of related entities. Part of <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D151687
kosarev
added a commit
that referenced
this issue
Jun 14, 2023
Removes the need to add and remove them manually depending on whether they are used in cvt*() functions. Also removes the compiler warnings about unused handlers when it happens to be the case. Part of <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D151688
kosarev
added a commit
that referenced
this issue
Jun 15, 2023
Part of <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D152897
kosarev
added a commit
that referenced
this issue
Jun 23, 2023
Now that we have proper support for optional operands, the standard LLVM machinery can take care of converting parsed instructions to MCInsts. There are likely more cases where the conversion can be done automatically, probably with some additional treatment. The plan is to address them separately. Part of <#62629>. Reviewed By: arsenm, foad Differential Revision: https://reviews.llvm.org/D153565
kosarev
added a commit
that referenced
this issue
Jun 29, 2023
This addresses the trivial cases that only require removing the operand classes and renaming related entities. Part of <#62629>. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D153965
kosarev
added a commit
that referenced
this issue
Jun 30, 2023
Also refine the definitions while there. Part of <#62629>. Reviewed By: mbrkusanin Differential Revision: https://reviews.llvm.org/D154061
kosarev
added a commit
that referenced
this issue
Jul 5, 2023
Simplifies some future changes needed for <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D154337
kosarev
added a commit
that referenced
this issue
Jul 5, 2023
addKImmFPOperands() duplicates the KImmFP-specific logic implemented in addLiteralImmOperand() and therefore can be removed. Part of <#62629>. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D154427
kosarev
added a commit
that referenced
this issue
Jul 5, 2023
Those are implicit helper operands and therefore don't need any parsers or printers. Part of <#62629>. Reviewed By: piotr, foad Differential Revision: https://reviews.llvm.org/D154432
kosarev
added a commit
that referenced
this issue
Jul 5, 2023
…omatically. Part of <#62629>. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D154433
Chenyang-L
pushed a commit
to intel/llvm
that referenced
this issue
Jul 11, 2023
Now that we have proper support for optional operands, the standard LLVM machinery can take care of converting parsed instructions to MCInsts. There are likely more cases where the conversion can be done automatically, probably with some additional treatment. The plan is to address them separately. Part of <llvm/llvm-project#62629>. Reviewed By: arsenm, foad Differential Revision: https://reviews.llvm.org/D153565
kosarev
added a commit
that referenced
this issue
Jul 13, 2023
The patch adds the support for 'noa16' operands in non-A16 variants of the instructions, fixes validation of A16 operands and eliminates the custom conversion to MCInst. Part of <#62629>. Reviewed By: arsenm Differential Revision: https://reviews.llvm.org/D155057
kosarev
added a commit
that referenced
this issue
Jul 13, 2023
…s automatically. Part of <#62629>. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D155061
kosarev
added a commit
that referenced
this issue
Jul 19, 2023
…automatically. Part of <#62629>. Reviewed By: foad Differential Revision: https://reviews.llvm.org/D155620
This was referenced Oct 16, 2023
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Jan 24, 2024
kosarev
added a commit
that referenced
this issue
Jan 24, 2024
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Jan 24, 2024
Eliminates the need to define them manually. Part of <llvm#62629>.
kosarev
added a commit
that referenced
this issue
Jan 25, 2024
Eliminates the need to define them manually. Part of <#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Jan 25, 2024
… class names. No need to have two names for the same thing. Also simplifies operand definitions. Part of <llvm#62629>.
kosarev
added a commit
that referenced
this issue
Jan 25, 2024
These do not seem to remove many repetitions or add clarity; many of them are only used once. Not having them also helps further work getting rid of the decoding functions defined using macros. Part of <#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Feb 12, 2024
Use templates instead. Part of <llvm#62629>.
AlfieRichardsArm
pushed a commit
to AlfieRichardsArm/llvm-project
that referenced
this issue
Feb 23, 2024
…lvm#81482) Use templates instead. Part of <llvm#62629>.
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this issue
Apr 18, 2024
These do not seem to remove many repetitions or add clarity; many of them are only used once. Not having them also helps further work getting rid of the decoding functions defined using macros. Part of <llvm/llvm-project#62629>.
qihangkong
pushed a commit
to rvgpu/llvm
that referenced
this issue
Apr 18, 2024
…he convention. Part of <llvm/llvm-project#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Apr 26, 2024
…perands. Their job is to discriminate between different types of operands, not to check if they are valid. For validation we can use conversion functions. Clears the road to generating predicates automatically. Part of <llvm#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Apr 29, 2024
…perands. Their job is to discriminate between different types of operands, not to check if they are valid. For validation we can use conversion functions. Clears the road to generating predicates automatically. Part of <llvm#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Apr 29, 2024
…perands. Their job is to discriminate between different types of operands, not to check if they are valid. For validation we can use conversion functions. Clears the road to generating predicates automatically. Part of <llvm#62629>.
kosarev
added a commit
to kosarev/llvm-project
that referenced
this issue
Apr 30, 2024
sabauma
pushed a commit
to sabauma/llvm-project
that referenced
this issue
May 1, 2024
…perands. (llvm#90251) Their job is to discriminate between different types of operands, not to check if they are valid. For validation we can use conversion functions. Clears the road to generating predicates automatically. Part of <llvm#62629>.
sabauma
pushed a commit
to sabauma/llvm-project
that referenced
this issue
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This is an umbrella ticket for the work on refining the assembler-related parts of the backend and common LLVM infrastructure. Includes elimination of workarounds, turning custom code into TableGen definitions, simplifications and fixing minor defects found during the work.
32f6b6b [AMDGPU][AsmParser] Refine parsing SDWA operands.
5114843 [AMDGPU][AsmParser] Refine SMRD offset definitions.
32f46ef [AMDGPU][AsmParser][NFC] Refine immediate operand definitions.
b06e5ad [AMDGPU][AsmParser][NFC] Simplify parsing cache policies.
905fa15 [AMDGPU][AsmParser] Distinguish literal and modifier SMEM offsets.
dbbab71 [AMDGPU][NFC] Eliminate the u32imm operand definition.
f0f8ae7 [AMDGPU][AsmParser] Fix matching immediate literals.
3d6b108 [AMDGPU] Remove the unused u8imm operand definition.
ce1aae4 [AMDGPU][AsmParser][NFC] Refine defining single-bit custom operands.
9976127 [AMDGPU][AsmParser][NFC] Refine defining i8- and i16-typed custom operands.
2d945ef [AMDGPU][NFC] Rename GFX10A16 operands.
0a6dc9a [AMDGPU][AsmParser] Refine parsing cache policy modifiers.
536b8c5 [AMDGPU][AsmParser] Remove the now-unused OptionalOperand structure.
fce7a7a [AMDGPU][AsmParser] Refine parsing instruction operands.
926acd2 (arcpatch-D137638) [AMDGPU][AsmParser] Remove extra checks on missing instruction modifiers.
af6b1f7 [AsmParser] Match mandatory operands following optional operands.
The text was updated successfully, but these errors were encountered: