Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please backport distro-independent detection of HIP in system paths #62853

Closed
cgmb opened this issue May 22, 2023 · 7 comments
Closed

Please backport distro-independent detection of HIP in system paths #62853

cgmb opened this issue May 22, 2023 · 7 comments
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' obsolete Issues with old (unsupported) versions of LLVM release:backport
Milestone
LLVM 16.0.X Release

Comments

@cgmb
Copy link
Contributor

cgmb commented May 22, 2023

The distro detection logic in LLVM tends to result in puzzling behaviour. If f859835 were backported to 16.0.X, then I could depend on LLVM working the same on Ubuntu, Mint, Pop!_OS, etc.
@EugeneZelenko EugeneZelenko added clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' release:backport and removed new issue labels May 22, 2023
@llvmbot
Copy link
Collaborator

llvmbot commented May 22, 2023

@llvm/issue-subscribers-clang-driver

@cgmb
Copy link
Contributor Author

cgmb commented Jun 13, 2023

/cherry-pick f859835

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 13, 2023

/cherry-pick f859835

Error: Command failed due to missing milestone.

@EugeneZelenko EugeneZelenko added this to the LLVM 16.0.X Release milestone Jun 13, 2023
@EugeneZelenko
Copy link
Contributor

/cherry-pick f859835

@llvmbot
Copy link
Collaborator

llvmbot commented Jun 13, 2023

/branch llvm/llvm-project-release-prs/issue62853

@llvmbot llvmbot mentioned this issue Jun 13, 2023
Closed
@llvmbot
Copy link
Collaborator

llvmbot commented Jun 13, 2023

/pull-request llvm/llvm-project-release-prs#471

@maflcko
Copy link
Contributor

maflcko commented Jul 25, 2023

Can this be closed, given that the backport pull has been closed?

@maflcko maflcko closed this as not planned Won't fix, can't repro, duplicate, stale Jul 25, 2023
@EugeneZelenko EugeneZelenko added the obsolete Issues with old (unsupported) versions of LLVM label Jul 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
clang:driver 'clang' and 'clang++' user-facing binaries. Not 'clang-cl' obsolete Issues with old (unsupported) versions of LLVM release:backport
Projects
None yet
Milestone
LLVM 16.0.X Release
Development

Successfully merging a pull request may close this issue.

PR for llvm/llvm-project#62853 llvm/llvm-project-release-prs
4 participants
@cgmb @maflcko @EugeneZelenko @llvmbot