You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Attributor seems to specially treat return of select, such that computeKnownFPClass is never called on the select instruction. In this example, it fails to add nofpclass(nan) to the return value. If you obscure the return value with some kind of call, it works:
The very first AA, at least the first one in order, is now gone.
AAReturnedValues was from a different time, one might say, a simpler
time. However, it was already rewamped once to use
`Attribute::getAssumedSimplifiedValues`, which is what the updated
AAPotentialValuesReturned now does too. To match the old behavior we
needed to avoid the helper AAReturnedFromReturnedValues and iterate the
return instructions explicitly, however, it is still less complexity
than it was before.
Fixes: llvm#63404
Noticed this when working on https://reviews.llvm.org/D153089
Attributor seems to specially treat return of select, such that
computeKnownFPClass
is never called on the select instruction. In this example, it fails to addnofpclass(nan)
to the return value. If you obscure the return value with some kind of call, it works:This will miss instruction flags and select clamping patterns
computeKnownFPClass
could recognizeThe text was updated successfully, but these errors were encountered: