hwasan compilation failures with COMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF
#64730
Labels
Comments
EugeneZelenko
added
build-problem
compiler-rt:hwasan
|
My bad, thanks for the report and the suggested fix! I've copied the fix into https://reviews.llvm.org/D158116 |
thurstond
added a commit
that referenced
this issue
Aug 16, 2023
This applies the fix as suggested by Gelbpunkt in #64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
|
Fix has landed |
|
Thank you for the quick response and fix! |
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 2, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 2, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 2, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 3, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 3, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 6, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
razmser
pushed a commit
to SuduIDE/llvm-project
that referenced
this issue
Oct 11, 2023
This applies the fix as suggested by Gelbpunkt in llvm#64730, Thanks to Florian Mayer for pointing out that my earlier patch D151262 had caused this regression. Differential Revision: https://reviews.llvm.org/D158116
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
When I compile the hwasan with
-DCOMPILER_RT_HWASAN_WITH_INTERCEPTORS=OFF, I get some build errors.Full cmake command
The error is as following:
I took a look at the offending file and all the includes for the headers that define these functions (https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/hwasan/hwasan_interceptors.cpp#L247) are in a conditionally compiled section (
HWASAN_WITH_INTERCEPTORS, https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/hwasan/hwasan_interceptors.cpp#L59-L502). That means ifHWASAN_WITH_INTERCEPTORSis not enabled, the methods won't exist. I believe the fix for this (that also works for me) is moving theiffor the conditional intercepts (https://github.com/llvm/llvm-project/blob/main/compiler-rt/lib/hwasan/hwasan_interceptors.cpp#L528) up right before theInitializeCommonInterceptorscall.The text was updated successfully, but these errors were encountered: