clang-format job on Buildkite is bogus

[asl]

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae
clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.

[llvmbot]

@llvm/issue-subscribers-bug

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.

[llvmbot]

@llvm/issue-subscribers-infrastructure

Consider e.g. https://buildkite.com/llvm-project/clang-ci/builds/3190#018a97ac-63f5-4517-ae31-3f185df940ae clang-format job failed, however, there is no way to figure out what is wrong: the output is simply missed from the log.

[metaflow]

@ldionne could you please take a look?

[ldionne]

Actually, I'll assign this to @tru since he's made a lot of progress on setting up clang-format for the whole monorepo. That will replace the Buildkite job we have for Clang.

[asl]

Will you please disable the job now as it simply makes everything else fail?

[ldionne]

a52560c

The issue is that someone (you?) added trailing whitespace. The job output isn't great, but it does say:

grep -rnI '[[:blank:]] clang/lib clang/include clang/docs
clang/lib/CodeGen/CGCoroutine.cpp:836:

[asl]

grep -rnI '[[:blank:]] clang/lib clang/include clang/docs
clang/lib/CodeGen/CGCoroutine.cpp:836:

And how one could deduce that this is something related to the failure? And not just some part of job script? Especially given that line 69 is absent from the log and one could clearly expect to see the error there (after ":" on the line above). Certainly, it is clear what is going on to whoever written this script, but for everyone else the output is very confusing. I spent quite some time trying to find the error message in various parts of the system including raw logs, etc.

That said, is it possible to annotate steps somehow? Is it possible to provide some error messages instead of just user command error: exit status 1?