-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should mergedParsedLibraries always emit an error ? #69112
Comments
Proposed fix: #69331. Note that the PR currently still emits another error. I think that it can be helpful to have some context for the precise error. (I wonder whether the function should return |
It cannot remove |
You can always move explicitly? |
|
This is what I mean: C++17 guarantees copy-elision in many cases, in the case where it does not you can move instead: the destructor will be called but that shouldn't have any effect on a diagnostic that has been moved from. |
I sounds like the conclusion is to have |
I modified #69331 to implement to what I understood is the suggestion. |
In #68661, @ftynse notes
about the following:
The text was updated successfully, but these errors were encountered: