You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I encountered this issue while working on #68753. Basically, some simd tests start failing when optimizations are enabled because they make invalid assumptions about floating-point conversions.
In order to reproduce this in the test suite, you can run libcxx/test/std/experimental/simd/simd.class/simd_ctor_conversion.pass.cpp with -O3 by adding // ADDITIONAL_COMPILE_FLAGS: -O3 to the test and it should reproduce. You should do this inside the Docker image environment to make sure it reproduces, see libcxx/utils/ci/run-buildbot-container.
The text was updated successfully, but these errors were encountered:
https://godbolt.org/z/f6Tqzcx8s
It seems that GCC works on this code well with -O3 option. Does that mean there are some problems with clang vector extension of type long double and the -O3 optimization?
I have no idea what the issue actually is. However, I tried to put the loop and calculations into internal layer and this seems to avoid the issue. But this may not actually fix the real issue.
When I tried debugging this, it seemed like the issue was that 1.0 as a double was not the same as 1.0l as a long double, but we use the equality operator to check they are equal in the test. But I'm happy if we only fix the test, my goal is to unblock #68753.
I encountered this issue while working on #68753. Basically, some simd tests start failing when optimizations are enabled because they make invalid assumptions about floating-point conversions.
Reproducer (from
libcxx/test/std/experimental/simd/simd.class/simd_ctor_conversion.pass.cpp
):Godbolt: https://godbolt.org/z/8vaKaMb4s
In order to reproduce this in the test suite, you can run
libcxx/test/std/experimental/simd/simd.class/simd_ctor_conversion.pass.cpp
with-O3
by adding// ADDITIONAL_COMPILE_FLAGS: -O3
to the test and it should reproduce. You should do this inside the Docker image environment to make sure it reproduces, seelibcxx/utils/ci/run-buildbot-container
.The text was updated successfully, but these errors were encountered: