Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ceff23c6e39118fbbfb053e70d786fad40987c5b breaks LLD tests on builders containing "dylib" in their name #75910

Closed
tbaederr opened this issue Dec 19, 2023 · 3 comments

Comments

@tbaederr
Copy link
Contributor

For example:

command line:1:22: error: RESPONSE-NOT: excluded string found in input
-implicit-check-not='dylib'
                     ^
<stdin>:3:36: note: found here
-syslibroot b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk
                                   ^~~~~
Input file: <stdin>
Check file: /b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/flat-namespace-dysyms.s
-dump-input=help explains the following input dump.
Input was:
<<<<<<
          1: -arch x86_64 
          2: -platform_version macos 11.0 11.0 
          3: -syslibroot b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk 
not:imp1                                        !~~~~                                                error: no match expected
          4: -lSystem 
          5: -fatal_warnings 
          6: -flat_namespace 
          7: -lSystem 
          8: b/1/llvm-x86_64-debian-dylib/build/tools/lld/test/MachO/Output/flat-namespace-dysyms.s.tmp/main.o 
          9: b/1/llvm-x86_64-debian-dylib/build/tools/lld/test/MachO/Output/flat-namespace-dysyms.s.tmp/baz.dylib 
         10: -o out 
         11: -t 
>>>>>>

I see that ceff23c is actually quite old, so something else must've changed, I guess?

@llvmbot
Copy link
Collaborator

llvmbot commented Dec 19, 2023

@llvm/issue-subscribers-lld-macho

Author: Timm Baeder (tbaederr)

For example:
command line:1:22: error: RESPONSE-NOT: excluded string found in input
-implicit-check-not='dylib'
                     ^
&lt;stdin&gt;:3:36: note: found here
-syslibroot b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk
                                   ^~~~~
Input file: &lt;stdin&gt;
Check file: /b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/flat-namespace-dysyms.s
-dump-input=help explains the following input dump.
Input was:
&lt;&lt;&lt;&lt;&lt;&lt;
          1: -arch x86_64 
          2: -platform_version macos 11.0 11.0 
          3: -syslibroot b/1/llvm-x86_64-debian-dylib/llvm-project/lld/test/MachO/Inputs/MacOSX.sdk 
not:imp1                                        !~~~~                                                error: no match expected
          4: -lSystem 
          5: -fatal_warnings 
          6: -flat_namespace 
          7: -lSystem 
          8: b/1/llvm-x86_64-debian-dylib/build/tools/lld/test/MachO/Output/flat-namespace-dysyms.s.tmp/main.o 
          9: b/1/llvm-x86_64-debian-dylib/build/tools/lld/test/MachO/Output/flat-namespace-dysyms.s.tmp/baz.dylib 
         10: -o out 
         11: -t 
&gt;&gt;&gt;&gt;&gt;&gt;

I see that ceff23c is actually quite old, so something else must've changed, I guess?

@firewave
Copy link

Looks like a duplicate of #75850.

@smeenai
Copy link
Collaborator

smeenai commented Dec 19, 2023

I pushed c77c366 as a short-term fix.

qihangkong pushed a commit to rvgpu/rvgpu-llvm that referenced this issue Apr 23, 2024
Make the `--implicit-check-not` account for the file extension as well.
This will still fail if we ever have a builder with `.dylib` in its
name, and we probably want a more robust solution, but this addresses
the immediate issue.

Fixes llvm/llvm-project#75850
Fixes llvm/llvm-project#75910
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants