-
Notifications
You must be signed in to change notification settings - Fork 10.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ceff23c6e39118fbbfb053e70d786fad40987c5b breaks LLD tests on builders containing "dylib" in their name #75910
Labels
Comments
@llvm/issue-subscribers-lld-macho Author: Timm Baeder (tbaederr)
For example:
I see that ceff23c is actually quite old, so something else must've changed, I guess? |
Looks like a duplicate of #75850. |
I pushed c77c366 as a short-term fix. |
qihangkong
pushed a commit
to rvgpu/rvgpu-llvm
that referenced
this issue
Apr 23, 2024
Make the `--implicit-check-not` account for the file extension as well. This will still fail if we ever have a builder with `.dylib` in its name, and we probably want a more robust solution, but this addresses the immediate issue. Fixes llvm/llvm-project#75850 Fixes llvm/llvm-project#75910
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
For example:
I see that ceff23c is actually quite old, so something else must've changed, I guess?
The text was updated successfully, but these errors were encountered: