Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple bots are broken after #76471 #77546

Closed
vitalybuka opened this issue Jan 10, 2024 · 10 comments
Closed

Multiple bots are broken after #76471 #77546

vitalybuka opened this issue Jan 10, 2024 · 10 comments
Assignees
@qiongsiwu
Labels
PGO Profile Guided Optimizations

Comments

@vitalybuka
Copy link
Collaborator

PR #76471 breaks windows
https://lab.llvm.org/buildbot/#/builders/127/builds/60635

#77508 is not enough
https://lab.llvm.org/buildbot/#/builders/127/builds/60651
@EugeneZelenko EugeneZelenko added the PGO Profile Guided Optimizations label Jan 10, 2024
@vitalybuka
Copy link
Collaborator Author

There is also
https://lab.llvm.org/buildbot/#/builders/238/builds/7395
which includes this patch

@vitalybuka
Copy link
Collaborator Author

And
https://lab.llvm.org/buildbot/#/builders/85/builds/21462

vitalybuka added a commit that referenced this issue Jan 10, 2024
@vitalybuka
Revert "[PGO] Fix instrprof-api.c on Windows (#77508)"
aa4c1e9 
Issue #77546

This reverts commit b6d1577.
vitalybuka added a commit that referenced this issue Jan 10, 2024
@vitalybuka
Revert "[PGO] Exposing PGO's Counter Reset and File Dumping APIs (#76471
a828cda 
)"

Issue #77546

This reverts commit 07c9189.
@vitalybuka vitalybuka changed the title Windows bot is broken after #76471 Multiple bots are broken after #76471 Jan 10, 2024
@vitalybuka
Copy link
Collaborator Author

Also https://lab.llvm.org/buildbot/#/builders/74/builds/24843

@qiongsiwu
Copy link
Contributor

@vitalybuka thanks for tracking the failures! I will take a look!

@qiongsiwu
Copy link
Contributor

#77831 fixes the bootstrap failures.

@qiongsiwu qiongsiwu mentioned this issue Jan 16, 2024
Merged
@qiongsiwu
Copy link
Contributor

#78285 posted to reland #76471.

qiongsiwu added a commit that referenced this issue Jan 22, 2024
@qiongsiwu
[PGO] Reland PGO's Counter Reset and File Dumping APIs #76471 (#78285)
4f21fb8 
#76471 caused buildbot failures
on Windows. For more details, see
#77546.

This PR revises the test and relands
#76471.
@qiongsiwu
Copy link
Contributor

qiongsiwu commented Jan 22, 2024 •
edited

#78285 has landed. I am monitoring the buildbots.

@qiongsiwu
Copy link
Contributor

Windows sanitizer build succeeded https://lab.llvm.org/buildbot/#/builders/127/builds/61230.

@qiongsiwu
Copy link
Contributor

Bootstrap looks fine as well https://lab.llvm.org/buildbot/#/builders/236/builds/8917. The only failing test case is failing for https://lab.llvm.org/buildbot/#/builders/236/builds/8916 as well.

@qiongsiwu
Copy link
Contributor

https://lab.llvm.org/buildbot/#/builders/168/builds/18218 is successful as well.

justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this issue Jan 28, 2024
@vitalybuka @justinfargnoli
Revert "[PGO] Fix instrprof-api.c on Windows (llvm#77508)"
c6a2685 
Issue llvm#77546

This reverts commit b6d1577.
justinfargnoli pushed a commit to justinfargnoli/llvm-project that referenced this issue Jan 28, 2024
@vitalybuka @justinfargnoli
Revert "[PGO] Exposing PGO's Counter Reset and File Dumping APIs (llv…
cd9edf9 
…m#76471)"

Issue llvm#77546

This reverts commit 07c9189.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@qiongsiwu qiongsiwu

Labels
PGO Profile Guided Optimizations
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@qiongsiwu @vitalybuka @EugeneZelenko