Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LIBCXXABI_USE_LLVM_UNWINDER=ON breaks PGO build #78487

Closed
aaupov opened this issue Jan 17, 2024 · 1 comment · Fixed by #78869
Closed

LIBCXXABI_USE_LLVM_UNWINDER=ON breaks PGO build #78487

aaupov opened this issue Jan 17, 2024 · 1 comment · Fixed by #78869
Labels
cmake Build system in general and CMake in particular PGO Profile Guided Optimizations

Comments

@aaupov
Copy link
Contributor

aaupov commented Jan 17, 2024 •
edited by ldionne
Loading

This was caused by #77687
Repro: https://llvm.org/docs/AdvancedBuilds.html#multi-stage-pgo
@EugeneZelenko EugeneZelenko added cmake Build system in general and CMake in particular and removed new issue labels Jan 17, 2024
@fhahn
Copy link
Contributor

fhahn commented Jan 17, 2024

Tagging PR #77687 to have it linked properly

@boomanaiden154 boomanaiden154 mentioned this issue Jan 21, 2024
Merged
@ldionne ldionne changed the title #77687 breaks PGO build LIBCXXABI_USE_LLVM_UNWINDER=ON breaks PGO build Jan 23, 2024
@ldionne ldionne removed their assignment Jan 23, 2024
ldionne pushed a commit that referenced this issue Jan 23, 2024
@tstellar
[CMake][PGO] Add libunwind to list of stage1 runtimes (#78869)
f2a2f80 
This fixes the build since 8f90e69
which made libcxxabi use llvm's libunwind by default.

Fixes #78487
@EugeneZelenko EugeneZelenko added the PGO Profile Guided Optimizations label Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cmake Build system in general and CMake in particular PGO Profile Guided Optimizations
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[CMake][PGO] Add libunwind to list of stage1 runtimes tstellar/llvm-project
4 participants
@fhahn @ldionne @aaupov @EugeneZelenko