-
Notifications
You must be signed in to change notification settings - Fork 11.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve the AST for the synthesized deduction guide #79798
Labels
clang:frontend
Language frontend issues, e.g. anything involving "Sema"
Comments
@llvm/issue-subscribers-clang-frontend Author: Haojian Wu (hokein)
Given the following CTAD code:
The synthesized deduction guide from the constructor is:
Note that the function parameter type is canonicalized to |
This was referenced May 7, 2024
zyn0217
added a commit
that referenced
this issue
Jul 22, 2024
… CTAD guides (#99840) This seems to be low-hanging fruit: We could remove all calls to `Context.getCanonicalTemplateArgument()` and gain a better diagnostic/AST. The non-canonical template arguments shouldn't make a difference when synthesizing a CTAD guide, so this is intended to be an NFC. Closes #79798
sgundapa
pushed a commit
to sgundapa/upstream_effort
that referenced
this issue
Jul 23, 2024
… CTAD guides (llvm#99840) This seems to be low-hanging fruit: We could remove all calls to `Context.getCanonicalTemplateArgument()` and gain a better diagnostic/AST. The non-canonical template arguments shouldn't make a difference when synthesizing a CTAD guide, so this is intended to be an NFC. Closes llvm#79798
yuxuanchen1997
pushed a commit
that referenced
this issue
Jul 25, 2024
… CTAD guides (#99840) This seems to be low-hanging fruit: We could remove all calls to `Context.getCanonicalTemplateArgument()` and gain a better diagnostic/AST. The non-canonical template arguments shouldn't make a difference when synthesizing a CTAD guide, so this is intended to be an NFC. Closes #79798
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Given the following CTAD code:
The synthesized deduction guide from the constructor is:
Note that the function parameter type is canonicalized to
type-parameter-0-1
, this is suboptimal. I think it is better to show a normalU
.The text was updated successfully, but these errors were encountered: