[Clang-Tidy] Create bugprone-string-view-data-usage check

[PiotrZSL]

I'm adding this here so, i wouldn't forget.
I run into this issue personally.

Background:

void something(std::string s);

int main()
{
   std::string_view sv("something");
   sv = sv.substr(0, 5);
   something(sv.data());
}

Because constructor in std::string that take std::string_view is implicit, this forces developer to be more ... productive.
Problem is that in such case .data() may not be null terminated or may not point to proper string.

Enforce:
Find all calls to std::string_view::data, that are passed to method/function, where other parameter isnt an std::string_view::length/size.

[llvmbot]

@llvm/issue-subscribers-clang-tidy

Author: Piotr Zegar (PiotrZSL)

I'm adding this here so, i wouldn't forget. I run into this issue personally.

Background:

void something(std::string s);

int main()
{
   std::string_view sv("something");
   sv = sv.substr(0, 5);
   something(sv.data());
}

Because constructor in std::string that take std::string_view is implicit, this forces developer to be more ... productive.
Problem is that in such case .data() may not be null terminated or may not point to proper string.

Enforce:
Find all calls to std::string_view::data, that are passed to method/function, where other parameter isnt an std::string_view::length/size.