Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[flang][beginner] Clean-up function types creation in Optimizer/Builder/Runtime files #83290

Open
vzakhari opened this issue Feb 28, 2024 · 1 comment
Labels
enhancement Improving things as opposed to bug fixing, e.g. new or missing feature flang:ir

Comments

@vzakhari
Copy link
Contributor

This comes up from @jeanPerier's comment https://github.com/llvm/llvm-project/pull/83219/files#r1506118851

We'd better use fir::runtime::getModel instead of direct MLIR/FIR types creation in Numeric.cpp, Reduction.cpp, Transformational.cpp, etc.

@vzakhari vzakhari added enhancement Improving things as opposed to bug fixing, e.g. new or missing feature flang Flang issues not falling into any other category labels Feb 28, 2024
@EugeneZelenko EugeneZelenko added flang:ir and removed flang Flang issues not falling into any other category labels Feb 28, 2024
@llvmbot
Copy link
Collaborator

llvmbot commented Feb 28, 2024

@llvm/issue-subscribers-flang-ir

Author: Slava Zakharin (vzakhari)

This comes up from @jeanPerier's comment https://github.com//pull/83219/files#r1506118851

We'd better use fir::runtime::getModel instead of direct MLIR/FIR types creation in Numeric.cpp, Reduction.cpp, Transformational.cpp, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improving things as opposed to bug fixing, e.g. new or missing feature flang:ir
Projects
None yet
Development

No branches or pull requests

3 participants